Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-check reporter shows clippy as step under random job #83

Open
wmmc88 opened this issue Oct 8, 2023 · 0 comments
Open

github-check reporter shows clippy as step under random job #83

wmmc88 opened this issue Oct 8, 2023 · 0 comments

Comments

@wmmc88
Copy link

wmmc88 commented Oct 8, 2023

When using github-check reporter, a PR's checks tab will show clippy-action's check under a random job.

 - name: Run Cargo Clippy
        uses: giraffate/clippy-action@v1
        with:
          tool_name: Clippy
          clippy_flags: --locked --profile ${{ matrix.cargo_profile }} --all-targets -- -D warnings
          reporter: ${{ github.event_name == 'pull_request' && 'github-pr-review' || 'github-check' }}
          github_token: ${{ secrets.GITHUB_TOKEN }}
          filter_mode: nofilter
          fail_on_error: true

When run with the above config (and triggered by a push), the resulting check will show up under a random job (i think its the first job to start). Example:
image

The above clippy check(triggered by push) is a step in the Lint job, but in the Checks tab of the PR, it shows under the Test Job (on other executions, it shows under different Jobs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant