Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic OCaml bindings #14

Closed
Spriithy opened this issue Nov 13, 2017 · 6 comments
Closed

Add basic OCaml bindings #14

Spriithy opened this issue Nov 13, 2017 · 6 comments

Comments

@Spriithy
Copy link

Since your plugin is the only actual Ocaml plugin up to date on the Jetbrain repositories, could you simply add an extra binding for .ml files as OCaml files (with a dedicated icon).

Binding .ml files to Reason files works fine, but is not quite the expected behavior.

Thanks in advance of your consideration.

@giraud
Copy link
Owner

giraud commented Nov 13, 2017

I am not sure to understand what you expect:

  1. add a file type association to .ml files with a specific icon but still use reason syntax highlighting,
  2. change the syntax highlighting to work with ocaml

@Spriithy
Copy link
Author

I think I would like to have a regular OCaml support since it doesn't appear to be any easy to install & go tool.

That essentially means change the syntax highlighting to work with ocaml and add a file type association to .ml files with a specific icon

@giraud
Copy link
Owner

giraud commented Nov 13, 2017

This is clearly not the goal of this project.
But I understand that seeing some ocaml in parallel with reason might be interesting.
If I can share enough code between reason and ocaml, I might try to have a very lightweight syntax highlighting, but I think it will never be satisfying for ocaml coders. I will think about it for the next releases, but, really, ocaml is not a priority for this plugin.

@Spriithy
Copy link
Author

I hope to see you do well in that regard :) !

Good luck & keep up the good work

@giraud
Copy link
Owner

giraud commented Nov 14, 2017

In fact, in version 0.25, I quickly added a lightweight ocaml mode so you can have file association and no incorrect parser errors.
It's a start. but I might be not very active on the ocaml side.

issue_14

I hope it's a little better like that.

@Spriithy
Copy link
Author

Looks great !

I think it is now suited to address this topic in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants