Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit hash is not correct when used with maven-release-plugin #235

Open
salyh opened this issue Jan 13, 2016 · 4 comments
Open

Commit hash is not correct when used with maven-release-plugin #235

salyh opened this issue Jan 13, 2016 · 4 comments

Comments

@salyh
Copy link

salyh commented Jan 13, 2016

maven-git-commit-id-plugin (2.2.0) determine wrong commit (548df55) when used with maven-release-plugin. It should point to 6e8a477.

[maven-release-plugin] prepare for next development iteration
Commit:
548df55e32bea673970071bf57b21b9e763e5208 [548df55]

[maven-release-plugin] prepare release v0.0.26
Commit:
6e8a477e3a35cf7d7fbd55ec602587e1fb18195d [6e8a477]
@ktoso
Copy link
Collaborator

ktoso commented Mar 26, 2016

I fear this may be simply because "during which phase the plugin is run"... If you'd be able to investigate in which phase we'd be able to get the right id, if possible, that'd be awesome I currently do not have the time to research that

@damnhandy
Copy link
Contributor

I'll dig into this @ktoso since after #240, it clear that the release plugin is doing some weird stuff. It seems to be temporally mucking with the git metadata during the prepare and release process. This bothers me. The maven-git-commit-id-plugin is simply reading the metadata that is available to the git repo. With #240, it was changing the origin URI to include credentials. I would not be surprised to see it doing something else. I'll post back when I find more.

@ktoso
Copy link
Collaborator

ktoso commented Mar 27, 2016

Thanks a lot for the help!

@TheSnoozer
Copy link
Collaborator

TheSnoozer commented Sep 20, 2017

I would consider the following the most common way to perform a release:

general guide / docs:
http://central.sonatype.org/pages/ossrh-guide.html

source code
https://maven.apache.org/maven-release/maven-release-plugin/source-repository.html
svn checkout http://svn.apache.org/repos/asf/maven/release/tags/maven-release-2.5.3/maven-release-plugin maven-release-plugin

all interesting mojo's reference the maven-release-manager version 2.5.3
https://maven.apache.org/maven-release/maven-release-manager/source-repository.html
svn checkout http://svn.apache.org/repos/asf/maven/release/tags/maven-release-2.5.3/maven-release-manager maven-release-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants