-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit hash is not correct when used with maven-release-plugin #235
Comments
I fear this may be simply because "during which phase the plugin is run"... If you'd be able to investigate in which phase we'd be able to get the right id, if possible, that'd be awesome I currently do not have the time to research that |
I'll dig into this @ktoso since after #240, it clear that the release plugin is doing some weird stuff. It seems to be temporally mucking with the git metadata during the prepare and release process. This bothers me. The maven-git-commit-id-plugin is simply reading the metadata that is available to the git repo. With #240, it was changing the origin URI to include credentials. I would not be surprised to see it doing something else. I'll post back when I find more. |
Thanks a lot for the help! |
I would consider the following the most common way to perform a release:
general guide / docs: source code all interesting mojo's reference the maven-release-manager version |
maven-git-commit-id-plugin (2.2.0) determine wrong commit (548df55) when used with maven-release-plugin. It should point to 6e8a477.
The text was updated successfully, but these errors were encountered: