Skip to content

Commit

Permalink
mingw: disallow compile warnings during the build
Browse files Browse the repository at this point in the history
More than once, in this developer's past ignoring a compile warning
resulted in multiple days of bug hunting, just to find out that the
warning actually pointed to a serious problem like, say, an erroneous
64-bit -> 32-bit case (losing crucial information).

So let's just not ignore those warnings but make them fatal instead.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed Sep 7, 2017
1 parent 735da41 commit 2739df9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion configs/mingw32_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ CONFIG_DEBUG=y
# CONFIG_DEBUG_PESSIMIZE is not set
# CONFIG_DEBUG_SANITIZE is not set
# CONFIG_UNIT_TEST is not set
# CONFIG_WERROR is not set
CONFIG_WERROR=y
CONFIG_NO_DEBUG_LIB=y
# CONFIG_DMALLOC is not set
# CONFIG_EFENCE is not set
Expand Down
2 changes: 1 addition & 1 deletion configs/mingw64_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ CONFIG_DEBUG=y
# CONFIG_DEBUG_PESSIMIZE is not set
# CONFIG_DEBUG_SANITIZE is not set
# CONFIG_UNIT_TEST is not set
# CONFIG_WERROR is not set
CONFIG_WERROR=y
CONFIG_NO_DEBUG_LIB=y
# CONFIG_DMALLOC is not set
# CONFIG_EFENCE is not set
Expand Down

0 comments on commit 2739df9

Please sign in to comment.