Skip to content

Commit 0cfa8f4

Browse files
dschoGit for Windows Build Agent
authored and
Git for Windows Build Agent
committed
ci: work around a problem with HTTP/2 vs libcurl v8.10.0 (#5165)
This patch implements a work-around, basically for the sake of Git for Windows v2.46.2's CI build: The `macos-13` runner images still reference libcurl v8.10.0, which has a known flaw that breaks t5559.30. Let's detect this situation and skip that test case in that case. While at it, also backport the work-around for a flaky test case (t5512.40 "helper with refspec capability fails gracefully"). This fixes #5159.
2 parents 376ef07 + 42b4225 commit 0cfa8f4

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

Diff for: t/t5551-http-fetch-smart.sh

+9-1
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,15 @@ test_expect_success CMDLINE_LIMIT \
381381
)
382382
'
383383

384-
test_expect_success 'large fetch-pack requests can be sent using chunked encoding' '
384+
# This is a temporary work-around for libcurl v8.10.0 on the macos-* runners;
385+
# see https://github.com/git-for-windows/git/issues/5159 for full details
386+
test_lazy_prereq UNBROKEN_HTTP2 '
387+
test "$HTTP_PROTO" = HTTP/2 &&
388+
test -z "$(brew info -q curl 2>/dev/null |
389+
sed -n "/^Installed/{N;s/.*8\\.10\\.0.*/BROKEN HTTP2/p;}")"
390+
'
391+
392+
test_expect_success UNBROKEN_HTTP2 'large fetch-pack requests can be sent using chunked encoding' '
385393
GIT_TRACE_CURL=true git -c http.postbuffer=65536 \
386394
clone --bare "$HTTPD_URL/smart/repo.git" split.git 2>err &&
387395
{

0 commit comments

Comments
 (0)