fixup??? Always auto-gc after calling a fast-import transport

dscho · dscho · commit aaa363e5b2b1 · 2022-11-03T12:36:35.000+01:00
Needed by `rs/no-more-run-command-v`.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/transport-helper.c b/transport-helper.c
@@ -570,10 +570,11 @@ static int fetch_with_import(struct transport *transport,
 	}
 	strbuf_release(&buf);
 	if (auto_gc) {
-		const char *argv_gc_auto[] = {
-			"gc", "--auto", "--quiet", NULL,
-		};
-		run_command_v_opt(argv_gc_auto, RUN_GIT_CMD);
+		struct child_process cmd = CHILD_PROCESS_INIT;
+
+		cmd.git_cmd = 1;
+		strvec_pushl(&cmd.args, "gc", "--auto", "--quiet", NULL);
+		run_command(&cmd);
 	}
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -570,10 +570,11 @@ static int fetch_with_import(struct transport *transport,`
`570`	`570`	`}`
`571`	`571`	`strbuf_release(&buf);`
`572`	`572`	`if (auto_gc) {`
`573`		`- const char *argv_gc_auto[] = {`
`574`		`- "gc", "--auto", "--quiet", NULL,`
`575`		`- };`
`576`		`- run_command_v_opt(argv_gc_auto, RUN_GIT_CMD);`
	`573`	`+ struct child_process cmd = CHILD_PROCESS_INIT;`
	`574`	`+`
	`575`	`+ cmd.git_cmd = 1;`
	`576`	`+ strvec_pushl(&cmd.args, "gc", "--auto", "--quiet", NULL);`
	`577`	`+ run_command(&cmd);`
`577`	`578`	`}`
`578`	`579`	`return 0;`
`579`	`580`	`}`