Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New mingw-w64-clang version] clang: Build with PGO #4728

Closed
github-actions bot opened this issue Dec 4, 2023 · 3 comments · Fixed by git-for-windows/MINGW-packages#101
Closed

[New mingw-w64-clang version] clang: Build with PGO #4728

github-actions bot opened this issue Dec 4, 2023 · 3 comments · Fixed by git-for-windows/MINGW-packages#101

Comments

@github-actions
Copy link

github-actions bot commented Dec 4, 2023

clang: Build with PGO

msys2/MINGW-packages@4dd91d1

@dscho
Copy link
Member

dscho commented Dec 4, 2023

This seems relevant: https://llvm.org/docs/HowToBuildWithPGO.html claims that this can reduce compile times by up to 20%.

However, looking at the commit, I gather that it will conflict (this change is adjacent to this change). @rimrul do you want to take a crack at it?

@rimrul
Copy link
Member

rimrul commented Dec 4, 2023

/open pr

The workflow run was started

@rimrul
Copy link
Member

rimrul commented Dec 4, 2023

However, looking at the commit, I gather that it will conflict

That's a neat side effect of how update-clang-from-msys2.sh is implemented: sed knows no conflicts.

I am slightly confused why it didn't change Native to host here though. git-for-windows/MINGW-packages@547e0b3#diff-125e46f56c15d81bb2f9210bdcc4959baf788e9db4c0acfbff0148bf4416815dR218

Edit: I'm not confused anymore, it expects double quotes around the list of targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants