-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide installer option to install per-user even if user is admin #4758
Comments
Git for Windows uses InnoSetup to build the installer. There is an option to specify the required privileges, Having said that, I missed that InnoSetup 6.0.0 introduced a new option to allow overriding the install mode: However, it won't be as simple as merely adding that option to the |
@dscho, I went ahead and rebuilt the installer according to your suggestion above... and it just worked. GfW is installed under my user's %AppData% and works beautifully. I have re-installed it many times with various combinations of options but have yet to find a single issue. The nearest thing to a problem that I have encountered is that the Git Bash shortcut which Windows Explorer "helpfully" creates when you pin the app to the task bar referred to the path I scanned through As for the patch, I just replaced the entire
It appeared to me that |
Hmm. @fadein this would most likely be due to some sort of caching, as the information used for pinning refers to
It would still be nice to remove it, we have a dedicated section for removing such shortcuts in the installer definition. By the way, this is exactly what I was referring to careful vetting, going through the (admittedly long, almost 4k lines)
The
It would probably need to be changed to something like this: PrivilegesRequired=lowest
#ifndef OUTPUT_TO_TEMP
PrivilegesRequiredOverridesAllowed=dialog
#endif I do wonder, though, whether that incurs a change of behavior for the use case I actually want to support: installing into Besides, there is one rather big fall-out that we would suffer from this change: If we install into [include]
; include Git for Windows' system config in order
; to inherit settings like \`core.autocrlf\`
path = C:/Program Files (x86)/Git/etc/gitconfig
path = C:/Program Files/Git/etc/gitconfig This is crucial because that config contains settings that change Git's behavior, such as We could of course extend that There are millions of Visual Studio/GitHub Desktop users out there that would be negatively impacted if we rushed this change in the installer. This fact dictates that we need to tread very wisely here. The best course of action would be to make that MinGit change, verify that it actually works as intended, publish it with Git for Windows v2.46 scheduled for July 29th, 2024, and then wait an appropriate amount of time before integrating that |
Setup
defaults?
to the issue you're seeing?
Details
PowerShell-Core
Minimal, Complete, and Verifiable example
this will help us understand the issue.
I should not see UAC prompt and git should be installed to "$env:USERPROFILE\AppData\Local\Programs\Git", not to "C:\Program Files\Git"
I see UAC prompt in
user
scope and git is installed "C:\Program Files\Git" instead of "$env:USERPROFILE\AppData\Local\Programs\Git"URL to that repository to help us with testing?
** insert URL here **
The text was updated successfully, but these errors were encountered: