Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior of space/enter in . context menu on MacOS Sequoia 15.0 #1027

Open
mscott-versa opened this issue Oct 1, 2024 · 3 comments

Comments

@mscott-versa
Copy link

To reproduce:

  1. Press . key to bring up a commit's context menu.
  2. Navigate to menu item that needs either Space or Return key to be pressed.
  3. Press one of those keys to select the menu item.
  4. The selected menu item is not triggered:
    1. If Space, the Quick View... action is triggered instead.
    2. If Return, the Checkout "<name>" Branch action is triggered instead.

Expected behavior (prior to MacOS 15.0):

  1. Press . key to bring up a commit's context menu.
  2. Navigate to menu item that needs either Space or Return key to be pressed.
  3. Press either of those keys to select the menu item.
  4. The selected menu item is triggered.

System details:

  • MacBook Pro / M1 Pro
  • MacOS Sequoia 15.0
  • GitUp 1.4.2 (1051)

Demonstration video:

Key sequence in video:

. Up Right Space Escape

. Up Right Return

CleanShot.2024-10-01.at.14.33.12.mp4
@lucasderraugh
Copy link
Collaborator

Interesting, thanks for reporting.

@lucasderraugh
Copy link
Collaborator

Looks like it's conflicting with the shortcuts on menu items. Unfortunately it makes sense. In general keyboard shortcuts in contextual menus aren't recommended but it's the only discovery mechanism we have at the moment.

I think the correct way to resolve this is make a proper menu item that can operate on the current selection and you can discover short cuts that way, but the contextual menu won't have any shortcuts.

Screenshot 2024-10-07 at 1 17 14 PM

@dweiner13
Copy link

I love GitUp but this is a pretty frustrating bug, since I have muscle memory not only from all the years when it used to work, but also from every other menu in macOS.

Even having a . shortcut for the context menu, for the sake of keyboard-friendliness, seems pointless if the user is forced to switch to the mouse to actually use the menu anyway. (I'm thinking of the "Edit Branch" submenu which does not have any keyboard shortcuts, so there's no alternative except the mouse).

Not that I don't appreciate the difficulty of solving this problem, just adding my 2¢. I'd take a crack myself but don't have the ability to right now unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants