Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Sequoia 15.2 Update Broke Dark Mode #1042

Open
delacrixmorgan opened this issue Dec 17, 2024 · 7 comments
Open

macOS Sequoia 15.2 Update Broke Dark Mode #1042

delacrixmorgan opened this issue Dec 17, 2024 · 7 comments

Comments

@delacrixmorgan
Copy link

Ever since I've updated to Sequoia 15.2 on GitUp 1.4.2 (1051), the red branch UI is broken in dark mode. I've wondered if anyone faced the same issue.

Light Mode ☀️ Dark Mode 🌚
Screenshot 2024-12-17 at 10 22 28 AM Screenshot 2024-12-17 at 10 22 10 AM
@ruslankmlv
Copy link

I'm having the same issue after the update to 15.2 as well

@lucasderraugh
Copy link
Collaborator

Dang, so it's the upgrade that suddenly cause it. I had this only in 1 repo in particular and so I figured it was something related to #336 but the fact that switching to light mode reveals all is very weird.

Thanks for flagging this, I'll try to get some time this week to look at it as it's also driving me a bit up the wall.

@lucasderraugh
Copy link
Collaborator

Looks like if I remove the conditional on this and always multiply it works as expected:

if (!self.effectiveAppearance.matchesDarkAppearance) {
CGContextSetBlendMode(context, kCGBlendModeMultiply);
}

I don't really understand why though.

@richardtop
Copy link

Screenshot 2024-12-31 at 5 29 35 Screenshot 2024-12-31 at 5 28 59

@kangu
Copy link

kangu commented Jan 16, 2025

I have the same issue as well. It looks to be somehow intermittent though... it only happens on what seem to be large repositories with many commits (around 3000 for me) and the first time it loads, it looks ok, but the moment the focus state is activated on one of the nodes, the branch line disappears. I'm on GitUp 1.4.2 and Sequoia 15.2

@lucasderraugh
Copy link
Collaborator

@kangu I agree. I have some repos that work fine and others that don't. Given that I can't find any real common thread I may just through in a build that has my change above that appears to resolve the issue for reasons I don't understand. It's definitely a pretty obnoxious issue.

@mluisbrown
Copy link

I have the same issue and so far it's affecting all my repos. It's not a blocker though, I can still use GitUp fine with this issue, it just doesn't look as nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants