-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression in 1.3.4 - crash with lfs #892
Comments
I'm learning that libgit2 1.4.4 is a disaster 😅. I think I'm ultimately going to end up reverting to what we used to have in the interim as there just seems to be a lot broken. |
Could you also attach the crash report to this ticket? |
for sure, here you go: Translated Report (Full Report Below)Process: GitUp [7798] Date/Time: 2022-12-19 18:43:26.0526 -0800 Sleep/Wake UUID: 9BF383A0-AC6F-4047-8DFD-2E7825007DFF Time Awake Since Boot: 490000 seconds System Integrity Protection: enabled Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Termination Reason: Namespace SIGNAL, Code 11 Segmentation fault: 11 VM Region Info: 0 is not in any region. Bytes before following region: 4328538112 Kernel Triage: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread Thread 1:: com.apple.NSEventThread Thread 2: Thread 3: Thread 4: Thread 0 crashed with ARM Thread State (64-bit): Binary Images: External Modification Summary: VM Region Summary:
REGION TYPE SIZE COUNT (non-coalesced) Full Report{"app_name":"GitUp","timestamp":"2022-12-19 18:43:37.00 -0800","app_version":"1.3.4","slice_uuid":"c3c5302f-c0e1-3a2c-9a61-e5fe43d853ce","build_version":"1047","platform":1,"bundleID":"co.gitup.mac","share_with_app_devs":1,"is_first_party":0,"bug_type":"309","os_version":"macOS 12.1 (21C52)","incident_id":"94FC378F-8789-4BE2-8D28-85D05F08180C","name":"GitUp"}
], ] Model: MacBookPro18,2, BootROM 7429.61.2, proc 10:8:2 processors, 64 GB, SMC |
Thanks, I will likely roll a 1.3.5 this week that reverts the changes for libgit2. There is more fallout than I expected and I don't think the benefits of the new version outweigh the regressions. I'll try to revisit a new libgit2 version in the future, but my time to maintain this project is limited, therefore the focus is more on stability than feature work. |
I think this is related to this: libgit2/libgit2#6303 Looks like it is in the 1.5.0 build but not 1.4.4. I might try taking the change in to see if it resolves the issue. |
@FrancoisBlavoet Please let me know if the 1.3.5 continuous build fixes your crash. I was unable to reproduce the crash you observed, but applied the theoretical fix that seemed similar to your crash to the libgit2 1.4.4 changes. Going to close this ticket out as resolved, but feel free to reopen it if you are still hitting it in 1.3.5. If you are, any repro steps you can give would be much appreciated. Thanks! |
Git-lfs used to work well with Gitup, now each time I have an uncommited image, Gitup just crashes until I manually commit it from the command line.
The text was updated successfully, but these errors were encountered: