Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-applied virtual branch with default name is clobbered when creating a new virtual branch in workspace #5077

Open
tdgrunenwald opened this issue Oct 9, 2024 · 2 comments
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions

Comments

@tdgrunenwald
Copy link

Steps to reproduce

  1. Create branch and leave the name as default "Virtual branch"
  2. make and commit some changes
  3. unapply the branch
  4. create a new virtual branch
  5. observe that old changes are lost

Version

0.12.27

Platform

Linux, AppImage

@Byron Byron added bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions labels Oct 10, 2024
@Byron
Copy link
Collaborator

Byron commented Oct 10, 2024

Thanks a lot for reporting - I could easily reproduce this dangerous issue.

It's notable that the oplog contains all the changes, so it's possible to revert to a previous, good state.

Screenshot 2024-10-10 at 07 32 05

Above it's also visible that it deleted the previous branch, before creating a new one with the same name.

CC @Caleb-T-Owens

@tdgrunenwald
Copy link
Author

Thanks for noting the oplog. Let me know if there is any further information I can provide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions
Projects
None yet
Development

No branches or pull requests

2 participants