Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck on "Before we begin" screen #6134

Open
fingolfin opened this issue Jan 31, 2025 · 9 comments
Open

Stuck on "Before we begin" screen #6134

fingolfin opened this issue Jan 31, 2025 · 9 comments
Assignees
Labels
bug Something isn't working os:mac The MacOS platform UI Any broken visuals like layouts, colors etc.

Comments

@fingolfin
Copy link

Version

0.14.6

Operating System

macOS

Distribution Method

dmg (Mac OS - Apple Silicon)

Describe the issue

Just downloaded version 0.14.6 on my MacBook Pro M1 running macOS 12.7.6

I cannot get past the initial "Before we begin" screen. Simply because there is no button or widget that would allow me to:

Image

I tried to "Add Local Repository" but it does nothing, nor does "Clone Repository...".

I can click on "Account" and that shows me preferences for e.g. theming, but that by itself of course is not very interesting.

Maybe my relatively old OS version 12.7.6 is relevant?

How to reproduce (Optional)

No response

Expected behavior (Optional)

No response

Relevant log output (Optional)

@fingolfin fingolfin added the bug Something isn't working label Jan 31, 2025
@Byron
Copy link
Collaborator

Byron commented Feb 1, 2025

Thanks a lot for reporting!

On MacOS 15.3 (24D60) it does show the button as expected.

Image

It's likely related to the older-than-usual version of MacOS as it ships with an older browser.

Image Image

Could you investigate what the issue is? This is the button that probably is in the DOM, and with the dev-tools it should be possible to see what's happening.

I'd hope a CSS change can fix the issue.

CC @PavelLaptev

@Byron Byron added os:mac The MacOS platform UI Any broken visuals like layouts, colors etc. feedback requested Feedback was requested to help resolve the issue labels Feb 1, 2025
@fingolfin
Copy link
Author

So I clicked on the area where in your screenshot the button should be -- and that worked, i.e., it sent me to the next screen. So it seems the button is indeed there and in the DOM, but somehow invisible?

Unfortunately this happened before I had a chance to use the web inspector I don't know how to get back to the initial screen (presumably I have to delete some prefs file somewhere?); if you tell me how to get back, I am happy to try the web dev tools to see if I can figure out more.

@Byron Byron removed the feedback requested Feedback was requested to help resolve the issue label Feb 7, 2025
@Byron
Copy link
Collaborator

Byron commented Feb 7, 2025

This is super useful, thanks for trying and finding the invisible button :)! Must be something with CSS then.

Your help would definitely be appreciated as we don't have access to MacOS 12.7.6 for testing, unfortunately. This folder, "~/Library/Application Support/com.gitbutler.app", could be renamed or deleted to get back to the onboarding screen.

@fingolfin
Copy link
Author

Image

If I disable the --label-clr attribute some text becomes visible:

Image

@fingolfin
Copy link
Author

So a wild guess: the default rendering of the button is being disabled so that some other alternative "nicer" rendering takes precedence but that's not available in the old WebKit version on my machine?

I also notice a lot of "computed" colors are white, and in your screenshot the button is white text on a blue-green background. I see variable --btn-bg set to that color.

Image

But the actual background color is computed as transparent:

Image

@fingolfin
Copy link
Author

Maybe the color-mix or var logic is broken? I can "fix" it by dropping them:

Image

@Byron
Copy link
Collaborator

Byron commented Feb 7, 2025

Thanks so much for sharing your insights! It seems that @estib-vega has an idea on how to fix this.

@estib-vega
Copy link
Contributor

@fingolfin Thanks for reporting and helping figure this out!

I believe the color-mix is indeed the culprit here.
It seems that it is supported starting on Safari 16.2, see caniuse,
and that is only available starting on macOS 13.1, see Tauri docs on webkit versions.

Would you be able to update your macOS version? That might solve the issue

Thanks again and sorry for the inconvenience!

@fingolfin
Copy link
Author

I guess this kind of incompatibility is the downside of the approach chosen by Tauri.

Unfortunately updating the OS it not an option right now.

Would it perhaps be possible to detect the old Safari and just turn off mixing in transparency in this case (I don't understand why this is needed here anyway?)

In any case, I now know how to get past the initial screen, and so I can start experimenting with Git Butler once I find some free cycles. So far it seems as if this issue also affects other "default" buttons, such as the "Continue >" button seen when adding a local project at some point. Byt knowing the issue I can now easily work around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working os:mac The MacOS platform UI Any broken visuals like layouts, colors etc.
Projects
None yet
Development

No branches or pull requests

3 participants