Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Provide Brave Browser version of Gitcoin Chrome Extension #8

Closed
owocki opened this issue Dec 20, 2017 · 10 comments
Closed

Provide Brave Browser version of Gitcoin Chrome Extension #8

owocki opened this issue Dec 20, 2017 · 10 comments
Labels

Comments

@owocki
Copy link
Contributor

owocki commented Dec 20, 2017

requirements:

  • a way (preferably an automated script) to build the current codebase for Brave.
  • (just porting the existing codebase to Brave is not acceptable, as ongoing changes to upstream chrome extension will need to be merged downstream into Brave on an ongoing basis)
  • submit a request to add this browser extension to the brave store via https://community.brave.com/c/feature-requests/extension-requests
  • comment back when that's been accepted
@gitcoinbot
Copy link
Member

This issue now has a funding of 0.05 ETH (39.7 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $11227.2 more Funded OSS Work Available at: https://gitcoin.co/explorer

@owocki owocki added the ports label Dec 20, 2017
@step21
Copy link

step21 commented Dec 25, 2017

As far as I can tell, not many or no changes would be needed to the extension - as it can just use chrome extensions. However, the process to include it in their architecture is a bit more involved involving pull requests to brave repos. See metamask example here: brave/browser-laptop#9647 brave/vault-updater#43

@owocki
Copy link
Contributor Author

owocki commented Dec 27, 2017

the process to include it in their architecture is a bit more involved

architecture, do you mean archive?

i am more than happy to spend the funds on this instead.. given that it seems my inintial scope is infeasible

@step21
Copy link

step21 commented Dec 27, 2017

Architecture as in extension/update architecture. Maybe not the best word. On the one hand they keep it kind of limited, on the other hand they ship several password managers by default, so not sure what that means for inclusion of gitcoin.

@vs77bb
Copy link

vs77bb commented Jan 17, 2018

@step21 Do you want this one? @owocki if not, may be work poking around to see if anyone is interested!

@gasolin
Copy link
Collaborator

gasolin commented Jan 19, 2018

As I saw instead of build-in extensions, Brave doesn't allow 3rd party extensions. And Brave doesn't provide extension store or install new extension from the chrome extension store. @owocki I think this issue can be closed
http://youtube.com/watch?v=B7dvJrhXIbc

@owocki
Copy link
Contributor Author

owocki commented Jan 19, 2018

thanks...

@owocki owocki closed this as completed Jan 19, 2018
@gitcoinbot
Copy link
Member

The funding of 0.05 ETH (50.95 USD) attached has been claimed by @owocki.

@owocki, please leave a comment to let the funder (@owocki) and the other parties involved your implementation plan. If you don't leave a comment, the funder may expire your claim at their discretion.

@gitcoinbot
Copy link
Member

The funding of 0.05 ETH (50.95 USD) attached to this issue has been approved & issued to @owocki.

@step21
Copy link

step21 commented Jan 20, 2018

Extensions can be suggested for shipment with brave or installed manually from what I remember. For manual install, just the chrome extension will work. Maybe docs could be added for this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants