Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 11c41c5

Browse files
committedNov 29, 2024·
ensure consistent styling between review and final review
1 parent b37c6a3 commit 11c41c5

File tree

4 files changed

+55
-51
lines changed

4 files changed

+55
-51
lines changed
 

‎src/features/checker/components/ProjectEvaluationList/ProjectEvaluationList.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { DefaultLogo } from "@/assets";
12
import { IconLabel } from "@/components/IconLabel";
23
import { CircleStat } from "@/primitives/Indicators";
34
import { ListGrid, ListGridColumn } from "@/primitives/ListGrid";
@@ -31,7 +32,7 @@ export const ProjectEvaluationList = ({
3132
alt={item.name}
3233
className="aspect-square size-12 rounded-sm"
3334
onError={(event: React.SyntheticEvent<HTMLImageElement, Event>) => {
34-
event.currentTarget.src = "/images/grey-image.png";
35+
event.currentTarget.src = DefaultLogo;
3536
}}
3637
/>
3738
<span>{item.name}</span>

‎src/features/checker/components/ProjectReviewList/ProjectReviewList.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { DefaultLogo } from "@/assets";
12
import { IconLabel } from "@/components/IconLabel";
23
import { Button } from "@/primitives/Button";
34
import { CircleStat } from "@/primitives/Indicators";
@@ -27,7 +28,7 @@ export const ProjectReviewList = ({ reviewer, projects, action }: ProjectReviewL
2728
alt={item.name}
2829
className="aspect-square size-12 rounded-sm"
2930
onError={(event: React.SyntheticEvent<HTMLImageElement, Event>) => {
30-
event.currentTarget.src = "/images/grey-image.png";
31+
event.currentTarget.src = DefaultLogo;
3132
}}
3233
/>
3334
<span>{item.name}</span>

‎src/features/checker/pages/ReviewApplicationsPage/ReviewApplicationsPage.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export const ReviewApplicationsPage = () => {
4343
allocationStartDate={new Date()}
4444
allocationEndDate={new Date()}
4545
/>
46-
<div className="mx-auto flex max-w-[1440px] flex-col gap-6 px-20">
46+
<div className="mx-auto flex max-w-[1440px] flex-col gap-6 px-20">
4747
<div className="flex justify-start">
4848
<Button
4949
variant="secondry"

‎src/features/checker/pages/SubmitFinalEvaluationPage/SubmitFinalEvaluationPage.tsx

+50-48
Original file line numberDiff line numberDiff line change
@@ -113,58 +113,60 @@ export const SubmitFinalEvaluationPage = ({
113113
allocationStartDate={new Date()}
114114
allocationEndDate={new Date()}
115115
/>
116-
<div className="mx-auto flex max-w-[1440px]">
117-
<div className="flex flex-col gap-6 px-20 pt-6">
118-
<div className="flex flex-col gap-8">
119-
<Button
120-
value="Exit"
121-
icon={<Icon type={IconType.X} className="fill-red-700" />}
122-
className="flex h-8 w-fit justify-start gap-2 bg-red-50 p-4 text-red-700"
123-
/>
124-
<StatCardGroup stats={statCardsProps || []} justify="center" />
125-
</div>
126-
<div className="flex flex-col gap-8">
127-
<div className="flex flex-col gap-4">
128-
<div className="font-mono text-2xl font-medium leading-loose text-black">
129-
Review applications
130-
</div>
131-
<div className="font-mono text-base font-normal leading-7 text-grey-900">
132-
Evaluate projects here.
133-
</div>
116+
<div className="mx-auto flex max-w-[1440px] flex-col gap-6 px-20">
117+
<div className="flex justify-start">
118+
<Button
119+
variant="secondry"
120+
icon={<Icon type={IconType.CHEVRON_LEFT} />}
121+
onClick={() =>
122+
window.open(`https://manager.gitcoin.co/#/chain/${chainId}/round/${poolId}`)
123+
}
124+
value="back to round manager"
125+
/>
126+
</div>
127+
<StatCardGroup stats={statCardsProps || []} justify="center" />
128+
129+
<div className="flex flex-col gap-8">
130+
<div className="flex flex-col gap-4">
131+
<div className="font-mono text-2xl font-medium leading-loose text-black">
132+
Review applications
133+
</div>
134+
<div className="font-mono text-base font-normal leading-7 text-grey-900">
135+
Evaluate projects here.
134136
</div>
135-
<div className="flex flex-col gap-2">
136-
<div className="pb-1">
137-
<div className="flex items-center justify-between pb-1">
138-
<div className="font-mono text-2xl font-medium leading-loose text-black">
139-
{`Ready to submit (${ReadyApplicationsToSubmit.length})`}
140-
</div>
141-
<div className="flex gap-2">
142-
<Button value="Cancel" onClick={handleCancel} />
143-
<Button
144-
value={`Record (${numberOfOnchainEvaluations}) evaluations onchain`}
145-
disabled={Object.keys(projectEvaluations).length === 0}
146-
onClick={() => {
147-
setIsModalOpen(true);
148-
}}
149-
/>
150-
</div>
137+
</div>
138+
<div className="flex flex-col gap-2">
139+
<div className="pb-1">
140+
<div className="flex items-center justify-between pb-1">
141+
<div className="font-mono text-2xl font-medium leading-loose text-black">
142+
{`Ready to submit (${ReadyApplicationsToSubmit.length})`}
151143
</div>
152-
<div className="h-px bg-grey-300" />
153-
</div>
154-
155-
<div>
156-
{ReadyApplicationsToSubmit.length === 0 ? (
157-
<div className="font-mono text-base font-normal leading-7 text-grey-900">
158-
Evaluations that are ready to be submitted onchain will appear here once
159-
reviewed. Manager supports multiple reviewers.
160-
</div>
161-
) : (
162-
<ProjectEvaluationList
163-
projects={ReadyApplicationsToSubmit}
164-
action={handleUpdateFinalEvaluations}
144+
<div className="flex gap-2">
145+
<Button value="Cancel" onClick={handleCancel} />
146+
<Button
147+
value={`Record (${numberOfOnchainEvaluations}) evaluations onchain`}
148+
disabled={Object.keys(projectEvaluations).length === 0}
149+
onClick={() => {
150+
setIsModalOpen(true);
151+
}}
165152
/>
166-
)}
153+
</div>
167154
</div>
155+
<div className="h-px bg-grey-300" />
156+
</div>
157+
158+
<div>
159+
{ReadyApplicationsToSubmit.length === 0 ? (
160+
<div className="font-mono text-base font-normal leading-7 text-grey-900">
161+
Evaluations that are ready to be submitted onchain will appear here once reviewed.
162+
Manager supports multiple reviewers.
163+
</div>
164+
) : (
165+
<ProjectEvaluationList
166+
projects={ReadyApplicationsToSubmit}
167+
action={handleUpdateFinalEvaluations}
168+
/>
169+
)}
168170
</div>
169171
</div>
170172
</div>

0 commit comments

Comments
 (0)
This repository has been archived.