Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab completion not working #233

Open
2 tasks done
uloco opened this issue Jun 24, 2022 · 1 comment
Open
2 tasks done

tab completion not working #233

uloco opened this issue Jun 24, 2022 · 1 comment
Labels
enhancement Improve the expected

Comments

@uloco
Copy link
Contributor

uloco commented Jun 24, 2022

Please complete the following tasks

  • I have searched the discussions
  • I have searched the existing issues

Description

tab completion in zsh is not working.

I am using oh-my-zsh and have a rather complicated setup with fzf-tab etc. so I am not quite sure if this is a bug, not implemented yet or just a local config issue.

Version

git-stack 0.8.2

Steps to reproduce

  • type git s then key.
  • only native git commands are completed.
  • type git stack -- then key
  • still no completion shown

Actual Behaviour

No response

Expected Behaviour

No response

Debug Output

No response

@uloco uloco added the bug Not as expected label Jun 24, 2022
@uloco uloco changed the title Completion not working tab completion not working Jun 24, 2022
@epage epage added enhancement Improve the expected and removed bug Not as expected labels Jun 28, 2022
@epage
Copy link
Collaborator

epage commented Jun 28, 2022

This is not implemented yet. We could use clap_complete to generate the completions for several shells. If we go the build-time route, then we need to distribute them somehow so they get in the right place., It might be better for us to generate them at runtime. For bash, that would end up looking something like $(git stack completions --shell bash). We'll need to be careful to make sure we integrate with the git command's completions correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

2 participants