Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linguist: Typescript syntax highlighting breaking on certain regex following ! #4809

Closed
4 tasks done
infinnie opened this issue Mar 2, 2020 · 1 comment
Closed
4 tasks done

Comments

@infinnie
Copy link

infinnie commented Mar 2, 2020

Funnily enough, it appears this code breaks GitHub's syntax highlighting as well.

Forwarded from: microsoft/TypeScript-TmLanguage#806

Preliminary Steps

Please confirm you have...

Problem Description

When using the TypeScript as the language, syntax highlight breaks.

class Foo {
    public foo(): boolean {
        return !/[():\w]/.test('foo');
    }

    private bar(): void {}
}

The JavaScript one, unlike in VS Code however, works:

!/[():\w]/.test('foo');

It seems related to the aforementioned upstream bug.

URL of the affected repository:

Last modified on:

Expected language:

Detected language:

@Alhadis
Copy link
Collaborator

Alhadis commented Mar 2, 2020

It seems related to the aforementioned upstream bug.

And because it's an upstream bug, this issue shouldn't be reported here. 😉

Please see our troubleshooting section about syntax highlighting errors.

@Alhadis Alhadis closed this as completed Mar 2, 2020
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants