-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags not found #132
Comments
@wellDan28 actually |
I think that what causing this possibly bug is the following code(part of the '_getLastTags' function) github-release-notes/lib/src/Gren.js Lines 315 to 318 in 3e6b2e4
the this.options.tags.indexOf('all') >= 0 clause lets you use paging only if the tags parameter is 'all', so in my case where the tags parameter is two specific versions the paging is not working.I tried to remove this clause and it fixed the problem. |
I seem to be experiencing this issue as well
|
Mmh.. I see @wellDan28 how are you getting on? Are you actually trying to fix this one? |
The paging shouldn't really be a problem, especially when you don't specify I'll try and investigate a bit too. |
@alexcanessa I'll take a look at this issue today and tomorrow. I'll update you. |
I'm working on a fix. |
hey @alexcanessa I'm working on the tests to improve the coverage before we can merge this PR. github-release-notes/test/Gren.spec.js Lines 546 to 556 in 3e6b2e4
I don't understand why is it possible to enter two tags and ignore one of them on the same time. As far as I understand, if a user enter 2 tags he wants gren to have all the prs/issues/commit between these tags, and because of it he can't ignore a tag that he have asked for. What do you think? |
@wellDan28 I know it's a bit of a paradox but if you think logic-wise it makes sense: Are you saying that specifying exactly two tags should trump |
I find it's strange, IMO the only case for using I'l try to explain why this scenario interests me: |
Agreed 👍 |
Ok, so I'll change the test in #136 and will open a issue for allow use |
Hey all,
I'm trying to run gren release against two specific tags and get the following error :
I think that this is happens because my repository have plenty of tags, and gren doesn't use paging when request tags from github api.
stacktrace:
The text was updated successfully, but these errors were encountered: