-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Allow page size option (per_page) in listPullRequestFiles call #408
Comments
I for one am cool with this idea. But, are you sure we don't just fetch all pages by default? Many of our methods fetch all of the pages behind the scenes. We probably want to re-think how we implement paged methods in general. |
Based on https://github.com/github-tools/github/blob/master/lib/Repository.js, it seems that the only Repository call that requests all pages is Given this, it seems like there are a few possible improvements (not necessarily mutually exclusive):
|
The listPullRequests call allows an optional second parameter for options that include setting the page size for for a request. GitHub allows
per_page
to also be sent along for the call wrapped bylistPullRequestFiles
but this library doesn't allow options to be passed.I'm happy to submit a PR but want to know:
listPullRequestFilesWithOptions
?The text was updated successfully, but these errors were encountered: