-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java autobuild overrides maven wrapper only-script distributionType #2373
Comments
Looking at the change history of the autobuilder, it looks like this change was on purpose; commit message:
I assume there was an increase in reported failures after the wrapper switching its default behaviour from |
Yes, the autobuilder assumes that if no |
When using the maven wrapper
distributionType
only-script
autobuild will override the wrapper:See https://github.com/ArloL/chorito/actions/runs/9918944552/job/27404224920 for a full log.
My guess is that autobuild checks for the presence of the
maven-wrapper.jar
because if I add an empty file back autobuild will not trigger the override. Maybe the check can be changed to check formaven-wrapper.properties
or similar?In the meantime I will revert back to the
bin
distributionType
.The text was updated successfully, but these errors were encountered: