Skip to content

Incorrect suppression ids for a number of rules #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lcartey opened this issue Jul 5, 2023 · 0 comments · Fixed by #324
Closed

Incorrect suppression ids for a number of rules #323

lcartey opened this issue Jul 5, 2023 · 0 comments · Fixed by #324

Comments

@lcartey
Copy link
Collaborator

lcartey commented Jul 5, 2023

Affected rules

  • RULE-11-4
  • DIR-4-12
  • RULE-21-6
  • RULE-21-9
  • MEM51-CPP

Description

The query for RULE-11-4 includes the following:

not isExcluded(cast, Pointers1Package::castBetweenObjectPointerAndDifferentObjectTypeQuery()) and

When it should be:

not isExcluded(cast, Pointers1Package::conversionBetweenPointerToObjectAndIntegerTypeQuery()) and
```

This means the results of this query can only currently be deviated by incorrectly supplying `RULE-11-3`.

There are multiple rules which have this problem. I have scraped the repo looking for duplicated uses of the same query predicate, and listed the affected rules above.
@lcartey lcartey changed the title RULE-11-4: Incorrect suppression id Incorrect suppression ids for a number of rules Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant