Skip to content

Commit 54817d6

Browse files
owen-mcowen-mc
committed
barrier guard uses localTaintStep which no longer holds
1 parent 879baf2 commit 54817d6

File tree

1 file changed

+29
-3
lines changed

1 file changed

+29
-3
lines changed

‎go/ql/test/query-tests/Security/CWE-022/ZipSlip.expected‎

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,28 @@
11
edges
22
| UnsafeUnzipSymlinkGood.go:52:24:52:32 | definition of candidate | UnsafeUnzipSymlinkGood.go:61:53:61:61 | candidate | provenance | |
3-
| UnsafeUnzipSymlinkGood.go:61:53:61:61 | candidate | UnsafeUnzipSymlinkGood.go:61:31:61:62 | call to Join | provenance | FunctionModel |
3+
| UnsafeUnzipSymlinkGood.go:61:31:61:62 | []type{args} [array] | UnsafeUnzipSymlinkGood.go:61:31:61:62 | call to Join | provenance | MaD:795 |
4+
| UnsafeUnzipSymlinkGood.go:61:53:61:61 | candidate | UnsafeUnzipSymlinkGood.go:61:31:61:62 | []type{args} [array] | provenance | |
45
| UnsafeUnzipSymlinkGood.go:72:3:72:25 | ... := ...[0] | UnsafeUnzipSymlinkGood.go:76:24:76:38 | selection of Linkname | provenance | |
56
| UnsafeUnzipSymlinkGood.go:72:3:72:25 | ... := ...[0] | UnsafeUnzipSymlinkGood.go:76:70:76:80 | selection of Name | provenance | |
67
| UnsafeUnzipSymlinkGood.go:76:24:76:38 | selection of Linkname | UnsafeUnzipSymlinkGood.go:52:24:52:32 | definition of candidate | provenance | |
78
| UnsafeUnzipSymlinkGood.go:76:70:76:80 | selection of Name | UnsafeUnzipSymlinkGood.go:52:24:52:32 | definition of candidate | provenance | |
89
| ZipSlip.go:11:2:15:2 | range statement[1] | ZipSlip.go:12:24:12:29 | selection of Name | provenance | |
910
| ZipSlip.go:12:3:12:30 | ... := ...[0] | ZipSlip.go:14:20:14:20 | p | provenance | |
10-
| ZipSlip.go:12:24:12:29 | selection of Name | ZipSlip.go:12:3:12:30 | ... := ...[0] | provenance | MaD:747 |
11+
| ZipSlip.go:12:24:12:29 | selection of Name | ZipSlip.go:12:3:12:30 | ... := ...[0] | provenance | MaD:787 |
1112
| tarslip.go:15:2:15:30 | ... := ...[0] | tarslip.go:16:23:16:33 | selection of Name | provenance | |
12-
| tarslip.go:16:23:16:33 | selection of Name | tarslip.go:16:14:16:34 | call to Dir | provenance | MaD:762 |
13+
| tarslip.go:16:23:16:33 | selection of Name | tarslip.go:16:14:16:34 | call to Dir | provenance | MaD:803 |
14+
| tarslip.go:31:2:31:30 | ... := ...[0] | tarslip.go:35:23:35:33 | selection of Name | provenance | |
15+
| tarslip.go:35:23:35:33 | selection of Name | tarslip.go:35:14:35:34 | call to Dir | provenance | MaD:803 |
16+
| tarslip.go:50:2:50:30 | ... := ...[0] | tarslip.go:54:23:54:33 | selection of Name | provenance | |
17+
| tarslip.go:54:23:54:33 | selection of Name | tarslip.go:54:14:54:34 | call to Dir | provenance | MaD:803 |
18+
| tarslip.go:67:2:67:30 | ... := ...[0] | tarslip.go:71:23:71:33 | selection of Name | provenance | |
19+
| tarslip.go:71:23:71:33 | selection of Name | tarslip.go:71:14:71:34 | call to Dir | provenance | MaD:803 |
20+
| tarslip.go:85:2:85:30 | ... := ...[0] | tarslip.go:89:23:89:33 | selection of Name | provenance | |
21+
| tarslip.go:89:23:89:33 | selection of Name | tarslip.go:89:14:89:34 | call to Dir | provenance | MaD:803 |
1322
| tst.go:23:2:43:2 | range statement[1] | tst.go:29:20:29:23 | path | provenance | |
1423
nodes
1524
| UnsafeUnzipSymlinkGood.go:52:24:52:32 | definition of candidate | semmle.label | definition of candidate |
25+
| UnsafeUnzipSymlinkGood.go:61:31:61:62 | []type{args} [array] | semmle.label | []type{args} [array] |
1626
| UnsafeUnzipSymlinkGood.go:61:31:61:62 | call to Join | semmle.label | call to Join |
1727
| UnsafeUnzipSymlinkGood.go:61:53:61:61 | candidate | semmle.label | candidate |
1828
| UnsafeUnzipSymlinkGood.go:72:3:72:25 | ... := ...[0] | semmle.label | ... := ...[0] |
@@ -25,11 +35,27 @@ nodes
2535
| tarslip.go:15:2:15:30 | ... := ...[0] | semmle.label | ... := ...[0] |
2636
| tarslip.go:16:14:16:34 | call to Dir | semmle.label | call to Dir |
2737
| tarslip.go:16:23:16:33 | selection of Name | semmle.label | selection of Name |
38+
| tarslip.go:31:2:31:30 | ... := ...[0] | semmle.label | ... := ...[0] |
39+
| tarslip.go:35:14:35:34 | call to Dir | semmle.label | call to Dir |
40+
| tarslip.go:35:23:35:33 | selection of Name | semmle.label | selection of Name |
41+
| tarslip.go:50:2:50:30 | ... := ...[0] | semmle.label | ... := ...[0] |
42+
| tarslip.go:54:14:54:34 | call to Dir | semmle.label | call to Dir |
43+
| tarslip.go:54:23:54:33 | selection of Name | semmle.label | selection of Name |
44+
| tarslip.go:67:2:67:30 | ... := ...[0] | semmle.label | ... := ...[0] |
45+
| tarslip.go:71:14:71:34 | call to Dir | semmle.label | call to Dir |
46+
| tarslip.go:71:23:71:33 | selection of Name | semmle.label | selection of Name |
47+
| tarslip.go:85:2:85:30 | ... := ...[0] | semmle.label | ... := ...[0] |
48+
| tarslip.go:89:14:89:34 | call to Dir | semmle.label | call to Dir |
49+
| tarslip.go:89:23:89:33 | selection of Name | semmle.label | selection of Name |
2850
| tst.go:23:2:43:2 | range statement[1] | semmle.label | range statement[1] |
2951
| tst.go:29:20:29:23 | path | semmle.label | path |
3052
subpaths
3153
#select
3254
| UnsafeUnzipSymlinkGood.go:72:3:72:25 | ... := ...[0] | UnsafeUnzipSymlinkGood.go:72:3:72:25 | ... := ...[0] | UnsafeUnzipSymlinkGood.go:61:31:61:62 | call to Join | Unsanitized archive entry, which may contain '..', is used in a $@. | UnsafeUnzipSymlinkGood.go:61:31:61:62 | call to Join | file system operation |
3355
| ZipSlip.go:11:2:15:2 | range statement[1] | ZipSlip.go:11:2:15:2 | range statement[1] | ZipSlip.go:14:20:14:20 | p | Unsanitized archive entry, which may contain '..', is used in a $@. | ZipSlip.go:14:20:14:20 | p | file system operation |
3456
| tarslip.go:15:2:15:30 | ... := ...[0] | tarslip.go:15:2:15:30 | ... := ...[0] | tarslip.go:16:14:16:34 | call to Dir | Unsanitized archive entry, which may contain '..', is used in a $@. | tarslip.go:16:14:16:34 | call to Dir | file system operation |
57+
| tarslip.go:31:2:31:30 | ... := ...[0] | tarslip.go:31:2:31:30 | ... := ...[0] | tarslip.go:35:14:35:34 | call to Dir | Unsanitized archive entry, which may contain '..', is used in a $@. | tarslip.go:35:14:35:34 | call to Dir | file system operation |
58+
| tarslip.go:50:2:50:30 | ... := ...[0] | tarslip.go:50:2:50:30 | ... := ...[0] | tarslip.go:54:14:54:34 | call to Dir | Unsanitized archive entry, which may contain '..', is used in a $@. | tarslip.go:54:14:54:34 | call to Dir | file system operation |
59+
| tarslip.go:67:2:67:30 | ... := ...[0] | tarslip.go:67:2:67:30 | ... := ...[0] | tarslip.go:71:14:71:34 | call to Dir | Unsanitized archive entry, which may contain '..', is used in a $@. | tarslip.go:71:14:71:34 | call to Dir | file system operation |
60+
| tarslip.go:85:2:85:30 | ... := ...[0] | tarslip.go:85:2:85:30 | ... := ...[0] | tarslip.go:89:14:89:34 | call to Dir | Unsanitized archive entry, which may contain '..', is used in a $@. | tarslip.go:89:14:89:34 | call to Dir | file system operation |
3561
| tst.go:23:2:43:2 | range statement[1] | tst.go:23:2:43:2 | range statement[1] | tst.go:29:20:29:23 | path | Unsanitized archive entry, which may contain '..', is used in a $@. | tst.go:29:20:29:23 | path | file system operation |

0 commit comments

Comments
 (0)