Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM.com - false positive (TypeScript 3.7 support) #2159

Closed
kyranet opened this issue Oct 20, 2019 · 8 comments
Closed

LGTM.com - false positive (TypeScript 3.7 support) #2159

kyranet opened this issue Oct 20, 2019 · 8 comments
Assignees

Comments

@kyranet
Copy link

kyranet commented Oct 20, 2019

Description of the false positive

Error: Expression expected. is raised when using the optional chaining operator, currently supported in typescript@next, babel, and Chrome 80 (haven't checked other browsers).

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/kyranet/Skyra/snapshot/569ccd85531c5b99fb275b2dec67c9a89ac82d83/files/database/5.2.0.ts

@asgerf
Copy link
Contributor

asgerf commented Oct 21, 2019

Hi kyranet,

Thanks for the report. We plan to upgrade to TypeScript 3.7 shortly after a stable version is released.

@asger-semmle asger-semmle changed the title LGTM.com - false positive LGTM.com - false positive (TypeScript 3.7 support) Oct 30, 2019
@AlCalzone
Copy link

@asgerf I'm not sure if there's an issue for all of the new syntax additions:

  • optional chaining
  • nullish coalescing
  • declare inside classes

@asger-semmle
Copy link
Contributor

asger-semmle commented Nov 1, 2019

I'm not sure if there's an issue for all of the new syntax additions:

We don't have separate issues for each language feature. For now I think it's fine if you want to discuss other features from TypeScript 3.7 in this issue. We intend to add support for all of them at once.

declare inside classes

@AlCalzone I can't find any mention of this feature anywhere. Could you elaborate?

@AlCalzone
Copy link

It has been missing from both the beta and the RC release notes. I'll look it up for you

@AlCalzone
Copy link

microsoft/TypeScript#33509

@AlCalzone
Copy link

Scroll down a bit in the PR description

@asger-semmle
Copy link
Contributor

Thanks @AlCalzone! I didn't know about this feature so this was really helpful. I've added it to #2237.

@asger-semmle
Copy link
Contributor

The update went live earlier this week, and the syntax errors seem to have gone away as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants