Conversation
michaelnebel
force-pushed
the
csharp/updatestubs
branch
4 times, most recently
from
7a5c30b to
98062c9
Compare
Click to show differences in coveragecsharpGenerated file changes for csharp
- System,"``System.*``, ``System``",47,10819,54,5
+ System,"``System.*``, ``System``",47,10864,54,5
- Totals,,108,12901,400,9
+ Totals,,108,12946,400,9
- System,54,47,10819,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5512,5307
+ System,54,47,10864,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5547,5317 |
|
DCA looks good. |
michaelnebel
force-pushed
the
csharp/updatestubs
branch
from
9721091 to
653b1d4
Compare
There was a problem hiding this comment.
Copilot reviewed 369 out of 369 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
michaelnebel
force-pushed
the
csharp/updatestubs
branch
from
35ad361 to
21c483d
Compare
| @@ -3285,41 +3323,6 @@ summary | |||
| | Microsoft.VisualBasic;VBCodeProvider;VBCodeProvider;(System.Collections.Generic.IDictionary<System.String,System.String>);Argument[0].Element;Argument[this];taint;df-generated | | |||
| | Microsoft.Win32.SafeHandles;SafeFileHandle;SafeFileHandle;(System.IntPtr,System.Boolean);Argument[0];Argument[this].Field[System.Runtime.InteropServices.SafeHandle.handle];value;dfc-generated | | |||
| | Microsoft.Win32.SafeHandles;SafeWaitHandle;SafeWaitHandle;(System.IntPtr,System.Boolean);Argument[0];Argument[this].Field[System.Runtime.InteropServices.SafeHandle.handle];value;dfc-generated | | |||
| | Microsoft.Win32;PowerModeChangedEventHandler;BeginInvoke;(System.Object,Microsoft.Win32.PowerModeChangedEventArgs,System.AsyncCallback,System.Object);Argument[2];Argument[2].Parameter[delegate-self];value;hq-generated | | |||
There was a problem hiding this comment.
Is it expected that we loose so many rows?
There was a problem hiding this comment.
This is because some of dependencies have changed such that System.Windows.Extensions is no longer referenced in the updated versions of the packages. If this is of concern, I can take a look and see whether se should try to explicitly include these packages.
There was a problem hiding this comment.
I have added some extra dependencies. Maybe that is for the best. It will also be interesting to see what happens when we re-generate the models for .NET (for .NET 9).
Awaiting CI before setting ready for review again.
…ome more packages (that previously were transitive dependencies).
michaelnebel
force-pushed
the
csharp/updatestubs
branch
from
4184a96 to
c7908d6
Compare
…f the project referenes.
…n library methods.
michaelnebel
force-pushed
the
csharp/updatestubs
branch
from
c7908d6 to
42d65f9
Compare
2 participants
In this PR we
params ReadOnlySpan<...>method overloads.Added some extra projects due to prior breaking changes in .NET