Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for Fastify’s all method in both tests and the QL model so that routes registered with fastify.all are treated like any HTTP method.
- Include a new
fastify.all('/eval', …)test case and update expected results. - Extend
Fastify.qllto recognize"all"in route setups and adaptgetHttpMethod(). - Document the addition in the change-notes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/fastify.js | Add fastify.all('/eval', …) scenario |
| javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/HeuristicSourceCodeInjection.expected | Update provenance edges/nodes for new test |
| javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/CodeInjection.expected | Update expected alerts/provenance for new test |
| javascript/ql/lib/semmle/javascript/frameworks/Fastify.qll | Include "all" in RouteSetup and modify getHttpMethod() |
| javascript/ql/lib/change-notes/2025-04-30-fastify-all.md | Add note about all route handler support |
asgerf
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements modeling of
Fastify'sallmethod which handles requests across all HTTP methods with a single route definition.