Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse Command #9

Open
ncalteen opened this issue Oct 31, 2023 · 0 comments
Open

Inverse Command #9

ncalteen opened this issue Oct 31, 2023 · 0 comments

Comments

@ncalteen
Copy link

ncalteen commented Oct 31, 2023

👋 fellow Hubber! Love this action and its versatility.

One idea that came to mind that would be helpful would be to specify an opposite/inverse of a command that would force the continue output to be 'false'. Specifically I was thinking about approval workflows that happen in issues instead of PRs. Currently, this would have to be implemented with two different github/command steps (one for .approve and one for .deny).

Alternatively, it'd be helpful to combine them into one step:

- name: Approve Command
  id: approve
  uses: github/command@vX.X.X
  with:
    allowed_contexts: issue
    command: .approve
    opposite: .deny

What do you think?

Edit: I just realized that I probably worded this poorly. I know that further steps that check the continue output would not run because commenting with .deny would not match the expected keyword. What would probably work better would be to have a separate output that is set when the opposite command is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant