Replace explicit any types with proper TypeScript types (#59127)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: heiskr

src/content-linter/lib/linting-rules/rai-reusable-usage.ts

@@ -10,7 +10,7 @@ import type { RuleParams, RuleErrorCallback, Rule } from '../../types'
 interface Frontmatter {
   type?: string
   // Allow any additional frontmatter properties since we only care about 'type'
-  [key: string]: any
+  [key: string]: unknown
 }
 
 interface LiquidToken {

src/content-render/scripts/cta-builder.ts

@@ -18,6 +18,19 @@ interface CTAParams {
   ref_style?: string
 }
 
+const CTA_PARAM_KEYS: (keyof CTAParams)[] = ['ref_product', 'ref_plan', 'ref_type', 'ref_style']
+
+interface CTASchemaProperty {
+  type: string
+  name: string
+  description: string
+  enum: string[]
+}
+
+type CTASchemaProperties = {
+  [K in keyof CTAParams]-?: CTASchemaProperty
+}
+
 // Conversion mappings from old CTA format to new schema
 const ctaToTypeMapping: Record<string, string> = {
   'GHEC trial': 'trial',
@@ -153,27 +166,40 @@ function extractCTAParams(url: string): CTAParams {
   const urlObj = new URL(url)
   const ctaParams: CTAParams = {}
   for (const [key, value] of urlObj.searchParams.entries()) {
-    if (key.startsWith('ref_')) {
-      ;(ctaParams as any)[key] = value
+    if (key.startsWith('ref_') && CTA_PARAM_KEYS.includes(key as keyof CTAParams)) {
+      ctaParams[key as keyof CTAParams] = value
     }
   }
   return ctaParams
 }
 
+interface AjvErrorParams {
+  missingProperty?: string
+  allowedValues?: string[]
+  additionalProperty?: string
+}
+
+interface AjvError {
+  keyword: string
+  instancePath: string
+  message?: string
+  params: AjvErrorParams
+}
+
 // Process AJV validation errors into readable messages
-function formatValidationErrors(ctaParams: CTAParams, errors: any[]): string[] {
+function formatValidationErrors(ctaParams: CTAParams, errors: AjvError[]): string[] {
   const errorMessages: string[] = []
   for (const error of errors) {
     let message = ''
     if (error.keyword === 'required') {
-      message = `Missing required parameter: ${(error.params as any)?.missingProperty}`
+      message = `Missing required parameter: ${error.params.missingProperty}`
     } else if (error.keyword === 'enum') {
       const paramName = error.instancePath.substring(1)
       const invalidValue = ctaParams[paramName as keyof CTAParams]
-      const allowedValues = (error.params as any)?.allowedValues || []
+      const allowedValues = error.params.allowedValues || []
       message = `Invalid value for ${paramName}: "${invalidValue}". Valid values are: ${allowedValues.join(', ')}`
     } else if (error.keyword === 'additionalProperties') {
-      message = `Unexpected parameter: ${(error.params as any)?.additionalProperty}`
+      message = `Unexpected parameter: ${error.params.additionalProperty}`
     } else {
       message = `Validation error: ${error.message}`
     }
@@ -191,7 +217,7 @@ function validateCTAParams(params: CTAParams): { isValid: boolean; errors: strin
     return { isValid: true, errors: [] }
   }
 
-  const errors = formatValidationErrors(params, ajvErrors)
+  const errors = formatValidationErrors(params, ajvErrors as unknown as AjvError[])
   return {
     isValid: false,
     errors,
@@ -382,12 +408,14 @@ async function interactiveBuilder(): Promise<void> {
 
     // Required parameters
     console.log(chalk.white(`\nRequired parameters:`))
+    const schemaProps = ctaSchema.properties as CTASchemaProperties
 
     for (const requiredParam of ctaSchema.required) {
-      ;(params as any)[requiredParam] = await selectFromOptions(
+      const paramKey = requiredParam as keyof CTAParams
+      params[paramKey] = await selectFromOptions(
         requiredParam,
-        (ctaSchema.properties as any)[requiredParam].description,
-        (ctaSchema.properties as any)[requiredParam].enum,
+        schemaProps[paramKey].description,
+        schemaProps[paramKey].enum,
         prompt,
       )
     }
@@ -399,15 +427,16 @@ async function interactiveBuilder(): Promise<void> {
     const optionalProperties = allProperties.filter((prop) => !ctaSchema.required.includes(prop))
 
     for (const optionalParam of optionalProperties) {
+      const paramKey = optionalParam as keyof CTAParams
       const includeParam = await confirmChoice(
-        `Include ${(ctaSchema.properties as any)[optionalParam].name.toLowerCase()}?`,
+        `Include ${schemaProps[paramKey].name.toLowerCase()}?`,
         prompt,
       )
       if (includeParam) {
-        ;(params as any)[optionalParam] = await selectFromOptions(
+        params[paramKey] = await selectFromOptions(
           optionalParam,
-          (ctaSchema.properties as any)[optionalParam].description,
-          (ctaSchema.properties as any)[optionalParam].enum,
+          schemaProps[paramKey].description,
+          schemaProps[paramKey].enum,
           prompt,
         )
       }

src/content-render/tests/liquid-helpers.ts

@@ -3,14 +3,13 @@ import { afterAll, beforeAll, describe, expect, test, vi } from 'vitest'
 import { liquid } from '@/content-render/index'
 import languages from '@/languages/lib/languages-server'
 import { DataDirectory } from '@/tests/helpers/data-directory'
+import type { Context } from '@/types'
 
 describe('liquid helper tags', () => {
   vi.setConfig({ testTimeout: 60 * 1000 })
 
-  // Using 'any' type as context is a test fixture with dynamic properties set in beforeAll
-  const context: any = {}
-  // Using 'any' type as DataDirectory is from data-directory.ts which lacks type definitions
-  let dd: any
+  const context: Partial<Context> = {}
+  let dd: DataDirectory
   const enDirBefore = languages.en.dir
 
   beforeAll(() => {

src/content-render/tests/liquid-tags.ts

@@ -31,9 +31,10 @@ describe('liquid-tags script integration tests', () => {
         stdio: 'pipe',
         timeout: 30000,
       })
-    } catch (error: any) {
-      output = error.stdout + error.stderr
-      exitCode = error.status || 1
+    } catch (error: unknown) {
+      const execError = error as { stdout?: string; stderr?: string; status?: number }
+      output = (execError.stdout || '') + (execError.stderr || '')
+      exitCode = execError.status || 1
     }
 
     return { output, exitCode }

src/events/components/is-headless.ts

@@ -2,7 +2,7 @@
 
 declare global {
   interface Window {
-    GHDOCSPLAYWRIGHT: any
+    GHDOCSPLAYWRIGHT: boolean | number
   }
 }
 

src/frame/middleware/context/product-examples.ts

@@ -16,7 +16,7 @@ function getProductExampleData(
   try {
     return getDataByLanguage(`product-examples.${product}.${key}`, language)
   } catch (error) {
-    if (error instanceof Error && (error as any).code === 'ENOENT') return
+    if (error instanceof Error && 'code' in error && error.code === 'ENOENT') return
     throw error
   }
 }

src/frame/tests/find-page.ts

@@ -5,6 +5,7 @@ import { describe, expect, test, vi } from 'vitest'
 
 import Page from '@/frame/lib/page'
 import findPage from '@/frame/lib/find-page'
+import type { Page as PageType } from '@/types'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
@@ -31,7 +32,7 @@ describe('find page', () => {
 
     const redirectedPage = findPage(
       redirectToFind,
-      pageMap as any, // Using any due to type conflicts between different Page type definitions
+      pageMap as unknown as Record<string, PageType>,
       page.buildRedirects(),
     )
     expect(redirectedPage).toBeDefined()

src/observability/logger/middleware/get-automatic-request-logger.ts

@@ -33,7 +33,7 @@ export function getAutomaticRequestLogger() {
     const originalEnd = res.end
 
     // Override res.end to log when response completes
-    res.end = function (chunk?: any, encoding?: any) {
+    res.end = function (...args: unknown[]) {
       const responseTime = Date.now() - startTime
       const status = res.statusCode || 200
       const contentLength = res.getHeader('content-length') || '-'
@@ -59,7 +59,7 @@ export function getAutomaticRequestLogger() {
 
         // Don't log `/_next/` requests unless LOG_LEVEL is `debug` or higher
         if (url?.startsWith('/_next/') && logLevelNum < 3) {
-          return originalEnd.call(this, chunk, encoding)
+          return originalEnd.apply(this, args as Parameters<typeof originalEnd>)
         }
 
         // Choose color based on status code
@@ -80,7 +80,7 @@ export function getAutomaticRequestLogger() {
       }
 
       // Call the original end method to complete the response
-      return originalEnd.call(this, chunk, encoding)
+      return originalEnd.apply(this, args as Parameters<typeof originalEnd>)
     }
 
     next()

src/search/components/input/SearchContext.tsx

@@ -2,6 +2,11 @@ import { createContext, useContext, RefObject, SetStateAction, MutableRefObject
 import type { AIReference } from '../types'
 import type { AutocompleteSearchHit, GeneralSearchHit } from '@/search/types'
 
+export type TranslationFunction = (
+  strings: TemplateStringsArray | string,
+  ...values: unknown[]
+) => string
+
 export interface AutocompleteSearchHitWithUserQuery extends AutocompleteSearchHit {
   isUserQuery?: boolean
 }
@@ -29,7 +34,7 @@ export interface AskAIState {
 }
 
 export interface SearchContextType {
-  t: any
+  t: TranslationFunction
   generalSearchOptions: GeneralSearchHitWithOptions[]
   aiOptionsWithUserInput: AutocompleteSearchHitWithUserQuery[]
   generalSearchResultOnSelect: (selectedOption: GeneralSearchHit) => void

src/search/lib/routes/ai-search-autocomplete-route.ts

@@ -10,7 +10,7 @@ export async function aiSearchAutocompleteRoute(req: Request, res: Response) {
   // If no query is provided, we want to return the top 5 most popular terms
   // This is a special case for AI search autocomplete
   // So we use `force` to allow the query to be empty without the usual validation error
-  const force = {} as any
+  const force: { query?: string } = {}
   if (!req.query.query) {
     force.query = ''
   }