Skip to content

Commit 85533e6

Browse files
authored
Merge branch 'main' into desktop-disabling-repo-indicators
2 parents 94c5b59 + f61b9a7 commit 85533e6

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

content/actions/reference/authentication-in-a-workflow.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ You can use the `GITHUB_TOKEN` to make authenticated API calls. This example wor
7171
--data '{
7272
"title": "Automated issue for commit: ${{ github.sha }}",
7373
"body": "This issue was automatically created by the GitHub Action workflow **${{ github.workflow }}**. \n\n The commit hash was: _${{ github.sha }}_."
74-
}'
74+
}' \
75+
--fail
7576
```
7677
{% endraw %}
7778

content/developers/webhooks-and-events/securing-your-webhooks.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ When your secret token is set, {% data variables.product.product_name %} uses it
4141
{% if currentVersion == "free-pro-team@latest" or currentVersion ver_gt "enterprise-server@2.22" %}
4242
{% note %}
4343

44-
**Note:** For backward-compatibility, we also include the `X-Hub-Signature` header that is generated using the SHA-1 hash function. If possible, we recommend that you use the `X-Hub-Signature-256` header for improved security. The example below demonstrate using the `X-Hub-Signature-256` header.
44+
**Note:** For backward-compatibility, we also include the `X-Hub-Signature` header that is generated using the SHA-1 hash function. If possible, we recommend that you use the `X-Hub-Signature-256` header for improved security. The example below demonstrates using the `X-Hub-Signature-256` header.
4545

4646
{% endnote %}
4747
{% endif %}
@@ -80,6 +80,12 @@ def verify_signature(payload_body)
8080
end{% endif %}
8181
```
8282
83+
{% note %}
84+
85+
**Note:** Webhook payloads can contain unicode characters. If your language and server implementation specifies a character encoding, ensure that you handle the payload as UTF-8.
86+
87+
{% endnote %}
88+
8389
Your language and server implementations may differ from this example code. However, there are a number of very important things to point out:
8490
8591
* No matter which implementation you use, the hash signature starts with {% if currentVersion == "free-pro-team@latest" or currentVersion ver_gt "enterprise-server@2.22" or "github-ae@latest" %}`sha256=`{% elsif currentVersion ver_lt "enterprise-server@2.23" %}`sha1=`{% endif %}, using the key of your secret token and your payload body.

0 commit comments

Comments
 (0)