Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS displays error to anonymous #26167

Closed
1 task done
dan2k3k4 opened this issue Jun 22, 2023 · 4 comments
Closed
1 task done

CODEOWNERS displays error to anonymous #26167

dan2k3k4 opened this issue Jun 22, 2023 · 4 comments
Labels
content This issue or pull request belongs to the Docs Content team engineering Will involve Docs Engineering

Comments

@dan2k3k4
Copy link

Code of Conduct

What article on docs.github.com is affected?

If you visit https://github.com/github/docs/blob/main/.github/CODEOWNERS, you'll notice the linting error visible:

Unknown owner on line 10: make sure the team @github/oidc exists, is publicly visible, and has write access to the repository

…hardening-your-deployments/** @github/oidc

It is visible whether you're logged in or out of GitHub.

image

What changes are you suggesting?

Suggestion:

  • Hide linting errors unless you're either logged in to GitHub or have write access to the file

Perhaps, also set the team @github/oidc as public to fix the initial linting error.

Additional information

No response

@dan2k3k4 dan2k3k4 added the content This issue or pull request belongs to the Docs Content team label Jun 22, 2023
@welcome
Copy link

welcome bot commented Jun 22, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 22, 2023
@cmwilson21
Copy link
Contributor

@dan2k3k4 Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@cmwilson21 cmwilson21 added engineering Will involve Docs Engineering and removed triage Do not begin working on this issue until triaged by the team labels Jun 22, 2023
@rsese
Copy link
Member

rsese commented Jun 27, 2023

👋 ! That's expected with our setup:

GitHub's Docs team works on pre-production content in a private repo that regularly syncs with this public repo.

So internally in the private repo we might have some teams that will review particular changes but those teams won't be publicly visible.

@cmwilson21
Copy link
Contributor

Closing this issue per comment above 💛

Please take a look at our help wanted section to find open issues you can work on.

Thank you for your interest in improving GitHub Docs! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team engineering Will involve Docs Engineering
Projects
None yet
Development

No branches or pull requests

3 participants