Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples of jobs running in a container reference the old node:14.16 image #28440

Closed
1 task done
tvalenta opened this issue Sep 22, 2023 · 2 comments · Fixed by #28442
Closed
1 task done

Examples of jobs running in a container reference the old node:14.16 image #28440

tvalenta opened this issue Sep 22, 2023 · 2 comments · Fixed by #28442
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@tvalenta
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container#example-running-a-job-within-a-container

What part(s) of the article would you like to see updated?

The examples for Actions that run jobs in a container reference the image node:14.16. This image is old enough that actions/checkout@v4 will fail. It might account for issues such as actions/checkout#1474

While the example isn't wrong, referencing a more current version could prevent future confusion.

Additional information

No response

@tvalenta tvalenta added the content This issue or pull request belongs to the Docs Content team label Sep 22, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 22, 2023
@cmwilson21
Copy link
Contributor

@tvalenta Thank you for opening an issue and linking it to your PR! ✨

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Sep 25, 2023
@meowius
Copy link
Contributor

meowius commented Sep 25, 2023

@tvalenta 👋 Thanks so much for noticing this and opening an issue and PR. I'm checking with the Actions team about this, as we just updated some other lines in the docs toward a similar goal on Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@tvalenta @meowius @cmwilson21 and others