Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talk about Warning: Skip output 'secret' since it may contain secret. #34216

Closed
1 task done
jsoref opened this issue Aug 6, 2024 · 4 comments · Fixed by #34555
Closed
1 task done

Talk about Warning: Skip output 'secret' since it may contain secret. #34216

jsoref opened this issue Aug 6, 2024 · 4 comments · Fixed by #34555
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR

Comments

@jsoref
Copy link
Contributor

jsoref commented Aug 6, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/defining-outputs-for-jobs#overview

What part(s) of the article would you like to see updated?

Job outputs containing expressions are evaluated on the runner at the end of each job. Outputs containing secrets are redacted on the runner and not sent to {% data variables.product.prodname_actions %}.

Should:

  1. Include the current message from github/runner to improve SEO so that people will find the documentation
  2. Link to the advice on what to do:
    https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#example-masking-and-passing-a-secret-between-jobs-or-workflows

Additional information

Users complain about this: actions/runner#475 (comment)

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Aug 6, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 6, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 6, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thanks for opening an issue! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added the needs SME This proposal needs review from a subject matter expert label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

Copy link
Contributor

github-actions bot commented Sep 4, 2024

This is a gentle bump for the docs team that this issue is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Sep 4, 2024
@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR help wanted Anyone is welcome to open a pull request to fix this issue and removed SME stale The request for an SME has staled waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Sep 4, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thank you for your patience while our SME team reviewed! 💛

Should:

Our SME team agrees with your guidance. You, or anyone else, is welcome to open a PR to make this update ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants