Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention how to handle GitHub Container Registry when using gh actions-importer configure #34236

Open
1 task done
jsoref opened this issue Aug 7, 2024 · 2 comments
Open
1 task done
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Comments

@jsoref
Copy link
Contributor

jsoref commented Aug 7, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/migrating-to-github-actions/automated-migrations/migrating-from-circleci-with-github-actions-importer#configuring-credentials

What part(s) of the article would you like to see updated?

There's a block that suggests the experience will look like this:

$ gh actions-importer configure
✔ Which CI providers are you configuring?: CircleCI
Enter the following values (leave empty to omit):
✔ Personal access token for GitHub: ***************
✔ Base url of the GitHub instance: https://github.com
✔ Personal access token for CircleCI: ********************
✔ Base url of the CircleCI instance: https://circleci.com
✔ CircleCI organization name: mycircleciorganization
Environment variables successfully updated.

When I ran it, I saw something closer to this:

% gh actions-importer configure
✔ Which CI providers are you configuring?: CircleCI
Enter the following values (leave empty to omit):
✔ GitHub handle used to authenticate with the GitHub Container Registry:
✔ Personal access token to authenticate with the GitHub Container Registry:
✔ Personal access token for GitHub:
✔ Base url of the GitHub instance: https://github.com
✔ Personal access token for CircleCI:
✔ Base url of the CircleCI instance: https://circleci.com
✔ CircleCI organization name: mycircleciorganization
Environment variables successfully updated.

There's a section before that block that talks about each of the questions and how to prepare answers for them, it includes:

Create a GitHub personal access token (classic). For more information, see "Managing your personal access tokens."

Your token must have the workflow scope.

It should have a step for setting up a GHCR credential too.

Additional information

No response

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Aug 7, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 7, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 7, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thanks for opening an issue! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added the needs SME This proposal needs review from a subject matter expert label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

3 participants
@jsoref @nguyenalex836 and others