Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradicting information about port mappings in service containers #34459

Open
1 task done
hsnabszhdn opened this issue Sep 1, 2024 · 4 comments
Open
1 task done
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Comments

@hsnabszhdn
Copy link
Contributor

hsnabszhdn commented Sep 1, 2024

Code of Conduct

What article on docs.github.com is affected?

What part(s) of the article would you like to see updated?

In both pages linked about, it says that if you don't specify the port, it maps the host port to a randomly chosen port on the container:

About service containers / Mapping Docker host and service container ports

8080/udp Map a randomly chosen UDP port in the container to UDP port 8080 on the Docker host.

I think, it's the other way around: "Map a randomly chosen port on the Docker host to UDP port 8080 in the container"

Workflow syntax for GitHub Actions / jobs.<job_id>.services / Example: Using localhost

❌ When you specify the Docker host port but not the container port, the container port is randomly assigned to a free port.

I think, it should be: "When you specify the container port but not the Docker host port, the container port is randomly assigned to a free port."

Additional information

In the following page, I think the correct statement is used:

Accessing contextual information about workflow runs / job context / Example usage of the job context

✅ This example workflow configures a PostgreSQL service container, and automatically maps port 5432 in the service container to a randomly chosen available port on the host.

@hsnabszhdn hsnabszhdn added the content This issue or pull request belongs to the Docs Content team label Sep 1, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 1, 2024
@Jamilwel

This comment was marked as spam.

@Jamilwel

This comment was marked as spam.

@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 2, 2024
@nguyenalex836
Copy link
Contributor

@hsnabszhdn Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

4 participants