Skip to content

Table on subdomain isolation + pages overlaps sidebar #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tcbyrd opened this issue Sep 23, 2020 · 1 comment
Closed

Table on subdomain isolation + pages overlaps sidebar #56

tcbyrd opened this issue Sep 23, 2020 · 1 comment
Labels
bug An error or flaw that causes unintended or unexpected results design Will involve design/engineering

Comments

@tcbyrd
Copy link
Contributor

tcbyrd commented Sep 23, 2020

👋 Noticed this today when reviewing some content. Hope this is the right place to open this issue now.


On this page: https://docs.github.com/en/enterprise/2.22/user/github/working-with-github-pages/about-github-pages

The table on subdomain isolation with Pages overlaps the ToC and feedback buttons:
image

This is the case in all browsers I've tested on desktop with a wide enough viewport to put the ToC in the right-hand column. On mobile the table just gets clipped off so you have the scroll right, which is probably fine.

What feature or product is affected?

GitHub Pages + Enterprise documentation

What is the new or expected behavior?

Table should be the same width as the rest of the content in this column

Who does this affect?

Any users reading this page on desktop. Verified it looks the same in Chrome, Edge, & Safari.

What is the impact to users?

Unable to read ToC or click buttons without moving the table out of the way

Content strategy and implementation

Item Core DSP Ecosystem/API
Unified content strategy plan

Please link any in-flight PRs to this issue.

@zeke zeke added bug An error or flaw that causes unintended or unexpected results design Will involve design/engineering labels Sep 25, 2020
@zeke
Copy link
Contributor

zeke commented Sep 25, 2020

Thanks @tcbyrd. I'm seeing this too.

Hope this is the right place to open this issue now.

You're a bit early, but that's cool. 👍🏼

@sarahs sarahs closed this as completed Sep 28, 2020
jnidzwetzki referenced this issue in jnidzwetzki/docs Oct 6, 2022
* Port content from legacy website

Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error or flaw that causes unintended or unexpected results design Will involve design/engineering
Projects
None yet
Development

No branches or pull requests

2 participants