-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileError in Samsung Internet Browser #475
Comments
Ouch; thanks for letting us know. Unfortunately, it's not possible to avoid using FileReader within our polyfill right now. It's automatically used whenever you call the The only workaround right now that I can suggest is to trick the broken browsers into thinking that they don't have support for FileReader while the polyfill is loading: <script>
if (samsungGalax) {
BrokenFileReader = FileReader
window.FileReader = undefined
}
</script>
<script src="./fetch.js"></script>
<script>
if (samsungGalax) {
window.FileReader = BrokenFileReader
delete window.BrokenFileReader
}
</script> After this, the polyfill will continue to assume that the FileReader interface is unavailable (even though you've restored it) and will not try to use it. |
Yes, we do use
Hadn't even though of just forcing fetch to use the Polyfill… That should fix it of course - thanks for the hint! BTW: your code is missing semicolons |
@mislav I am hitting this as well. We happen to use It is not just Samsung: the LG-D855 is hit by this as well. Affected Android versions include Android 4.1 though 6.0 based on the data I see in Sentry. |
@wichert yep. I'm also seeing this bug manifesting itself on Chrome Mobile 38.0.1025 on Android 4.2 devices. |
Unfortunately this is a pretty vague bug report but at this point I don't really know how to debug it better 😞
We have an SPA that uses
fetch
(through https://github.com/stefanpenner/ember-fetch) and we're seeing a lot ofFileError
s in production, all coming from Samsung Galaxies (6 and 7). The specific error iswhich seems to be related to Chrome's
FileReader
implementation (see here and e.g. here). This is also the only indication I have for this being related to fetch at all since the only usage of theFileReader
API in our app bundle is within this library. Unfortunately we're not seeing any stack traces for this error in Sentry and I currently don't have an actual device to test this on.More specifically, all of these errors (we have about 13000 events for 3000 users) are on Android 6 with Samsung Browser5.0/Chrome 51.
The text was updated successfully, but these errors were encountered: