Skip to content

fix: replace deprecated log_access directive with Squid 5+ syntax #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mossaka merged 1 commit into from
Feb 4, 2026
+12 −13
Merged

fix: replace deprecated log_access directive with Squid 5+ syntax #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/squid-config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,24 +483,25 @@ describe('generateSquidConfig', () => {
port: defaultPort,
};
const result = generateSquidConfig(config);
// Squid 5+ uses ACL filter on access_log directive instead of deprecated log_access
expect(result).toContain('acl healthcheck_localhost src 127.0.0.1 ::1');
expect(result).toContain('log_access deny healthcheck_localhost');
expect(result).toContain('access_log /var/log/squid/access.log firewall_detailed !healthcheck_localhost');
// Ensure deprecated log_access directive is NOT present (removed in Squid 5+)
expect(result).not.toContain('log_access');
});

it('should place healthcheck filter before access_log directive', () => {
it('should place healthcheck ACL before access_log directive', () => {
const config: SquidConfig = {
domains: ['example.com'],
port: defaultPort,
};
const result = generateSquidConfig(config);
// Verify the order: ACL definition, then log_access deny, then access_log
// Verify the order: ACL definition comes before access_log that uses it
const aclIndex = result.indexOf('acl healthcheck_localhost');
const logAccessIndex = result.indexOf('log_access deny healthcheck_localhost');
const accessLogIndex = result.indexOf('access_log /var/log/squid/access.log');

const accessLogIndex = result.indexOf('access_log /var/log/squid/access.log firewall_detailed !healthcheck_localhost');

expect(aclIndex).toBeGreaterThan(-1);
expect(logAccessIndex).toBeGreaterThan(aclIndex);
expect(accessLogIndex).toBeGreaterThan(logAccessIndex);
expect(accessLogIndex).toBeGreaterThan(aclIndex);
});
});

Expand Down
8 changes: 3 additions & 5 deletions src/squid-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,12 +511,10 @@ pinger_enable off
# Note: For CONNECT requests (HTTPS), the domain is in the URL field
logformat firewall_detailed %ts.%03tu %>a:%>p %{Host}>h %<a:%<p %rv %rm %>Hs %Ss:%Sh %ru "%{User-Agent}>h"

# Don't log healthcheck probes from localhost
acl healthcheck_localhost src 127.0.0.1 ::1
log_access deny healthcheck_localhost

# Access log and cache configuration
access_log /var/log/squid/access.log firewall_detailed
# Don't log healthcheck probes from localhost (using ACL filter on access_log)
acl healthcheck_localhost src 127.0.0.1 ::1
access_log /var/log/squid/access.log firewall_detailed !healthcheck_localhost
cache_log /var/log/squid/cache.log
cache deny all

Expand Down
Loading