-
Notifications
You must be signed in to change notification settings - Fork 3
Configure filesystem, browser automation, and kubernetes MCP servers in stress test #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -33,6 +33,8 @@ mcp-servers: | |||||||
| filesystem: | ||||||||
| type: stdio | ||||||||
| container: "mcp/filesystem" | ||||||||
| env: | ||||||||
| ALLOWED_PATHS: "/workspace" | ||||||||
| mounts: | ||||||||
| - "/tmp/mcp-test-fs:/workspace:rw" | ||||||||
| memory: | ||||||||
|
|
@@ -50,6 +52,8 @@ mcp-servers: | |||||||
| puppeteer: | ||||||||
| type: stdio | ||||||||
| container: "mcp/puppeteer" | ||||||||
| env: | ||||||||
| PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: "false" | ||||||||
|
Comment on lines
+55
to
+56
|
||||||||
| env: | |
| PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: "false" | |
| # Rely on the mcp/puppeteer container's preinstalled Chromium; no extra env needed |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The container image has been changed from mcp/playwright to mcr.microsoft.com/playwright:v1.49.1-noble, but this appears to be incorrect. The image mcr.microsoft.com/playwright:v1.49.1-noble is the base Playwright browser testing framework image, not a Playwright MCP server.
Other workflows in this repository (such as smoke-codex.lock.yml, smoke-copilot.lock.yml, and daily-multi-device-docs-tester.lock.yml) consistently use mcr.microsoft.com/playwright/mcp, which is the official Playwright MCP Server image. The base Playwright image does not include the MCP protocol implementation needed to communicate with the MCP Gateway.
The container should be changed to mcr.microsoft.com/playwright/mcp to match the pattern used throughout the codebase and ensure the MCP server can properly communicate with the gateway.
| container: "mcr.microsoft.com/playwright:v1.49.1-noble" | |
| container: "mcr.microsoft.com/playwright/mcp" |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback value for KUBECONFIG is set to '/dev/null' when the secret is not available. While /dev/null is a valid Unix file path, it's not a valid Kubernetes config file. This could cause the Kubernetes MCP server to fail or behave unexpectedly when trying to read cluster configuration.
Consider using a more appropriate fallback such as:
- An empty string
''to indicate no config is available - A path to a dummy/empty config file if the server requires a file path
- Not setting the environment variable at all when the secret is missing
The current approach may result in misleading error messages from the Kubernetes MCP server when it attempts to parse /dev/null as a kubeconfig file.
| KUBECONFIG: "${{ secrets.KUBECONFIG || '/dev/null' }}" | |
| KUBECONFIG: "${{ secrets.KUBECONFIG || '' }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation references the incorrect Playwright container image
mcr.microsoft.com/playwright:v1.49.1-noble. This should be corrected tomcr.microsoft.com/playwright/mcpto match the proper MCP server image used elsewhere in the codebase.This documentation inconsistency will mislead users about the actual server configuration and should be updated along with the workflow configuration file.