Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/nightly-mcp-stress-test.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ mcp-servers:
container: "mcr.microsoft.com/playwright:v1.49.1-noble"
env:
PLAYWRIGHT_BROWSERS_PATH: "/ms-playwright"
# Launch options to prevent ERR_BLOCKED_BY_CLIENT errors in CI testing
# Security note: These flags disable web security features for testing purposes only
PLAYWRIGHT_LAUNCH_OPTIONS: '{"args": ["--disable-blink-features=AutomationControlled", "--disable-web-security", "--disable-features=IsolateOrigins,site-per-process"]}'
Comment on lines +99 to +101
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states "Lock file intentionally not modified per instructions," but this means the changes to the .md file will not take effect until the workflow is recompiled using gh aw compile nightly-mcp-stress-test. According to the codebase documentation, agentic workflows must be compiled from .md to .lock.yml files before they can run. Without updating the lock file, these environment variable changes will not be applied to the actual workflow execution. Either the lock file needs to be updated (recompiled), or if there's a specific reason not to update it, this should be clarified.

Copilot uses AI. Check for mistakes.
Comment on lines +99 to +101
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PLAYWRIGHT_LAUNCH_OPTIONS environment variable appears to be undocumented and there's no evidence in the codebase or standard Playwright MCP server documentation that this variable is supported. Environment variables should be verified as supported by the target container before being added to the configuration. Consider verifying whether the Playwright MCP server (mcr.microsoft.com/playwright/mcp) or the actual MCP server implementation supports this environment variable, or whether browser launch options need to be configured through a different mechanism (such as entrypoint arguments).

Suggested change
# Launch options to prevent ERR_BLOCKED_BY_CLIENT errors in CI testing
# Security note: These flags disable web security features for testing purposes only
PLAYWRIGHT_LAUNCH_OPTIONS: '{"args": ["--disable-blink-features=AutomationControlled", "--disable-web-security", "--disable-features=IsolateOrigins,site-per-process"]}'

Copilot uses AI. Check for mistakes.
Comment on lines +99 to +101
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling web security features (--disable-web-security, --disable-features=IsolateOrigins,site-per-process) creates significant security risks even in a test environment. These flags disable CORS, same-origin policy, and site isolation, which could expose the test environment to various attacks if malicious content is loaded. While the comment notes this is "for testing purposes only," consider whether these aggressive security bypasses are necessary. Alternative approaches might include: 1) configuring proper allowed origins/hosts (as done in the lock file's entrypointArgs), 2) using --disable-blink-features=AutomationControlled alone, or 3) investigating why ERR_BLOCKED_BY_CLIENT occurs and addressing the root cause (e.g., network policies, ad blockers, or container restrictions) rather than disabling security features.

Suggested change
# Launch options to prevent ERR_BLOCKED_BY_CLIENT errors in CI testing
# Security note: These flags disable web security features for testing purposes only
PLAYWRIGHT_LAUNCH_OPTIONS: '{"args": ["--disable-blink-features=AutomationControlled", "--disable-web-security", "--disable-features=IsolateOrigins,site-per-process"]}'
# Launch options to reduce CI-specific blocking (e.g., automation detection) without disabling web security
PLAYWRIGHT_LAUNCH_OPTIONS: '{"args": ["--disable-blink-features=AutomationControlled"]}'

Copilot uses AI. Check for mistakes.
wikipedia:
type: stdio
container: "mcp/wikipedia-mcp"
Expand Down