-
Notifications
You must be signed in to change notification settings - Fork 5
Fix Playwright ERR_BLOCKED_BY_CLIENT in nightly stress test #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -96,6 +96,9 @@ mcp-servers: | |||||||||||||||||
| container: "mcr.microsoft.com/playwright:v1.49.1-noble" | ||||||||||||||||||
| env: | ||||||||||||||||||
| PLAYWRIGHT_BROWSERS_PATH: "/ms-playwright" | ||||||||||||||||||
| # Launch options to prevent ERR_BLOCKED_BY_CLIENT errors in CI testing | ||||||||||||||||||
| # Security note: These flags disable web security features for testing purposes only | ||||||||||||||||||
| PLAYWRIGHT_LAUNCH_OPTIONS: '{"args": ["--disable-blink-features=AutomationControlled", "--disable-web-security", "--disable-features=IsolateOrigins,site-per-process"]}' | ||||||||||||||||||
|
Comment on lines
+99
to
+101
|
||||||||||||||||||
| # Launch options to prevent ERR_BLOCKED_BY_CLIENT errors in CI testing | |
| # Security note: These flags disable web security features for testing purposes only | |
| PLAYWRIGHT_LAUNCH_OPTIONS: '{"args": ["--disable-blink-features=AutomationControlled", "--disable-web-security", "--disable-features=IsolateOrigins,site-per-process"]}' |
Copilot
AI
Feb 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling web security features (--disable-web-security, --disable-features=IsolateOrigins,site-per-process) creates significant security risks even in a test environment. These flags disable CORS, same-origin policy, and site isolation, which could expose the test environment to various attacks if malicious content is loaded. While the comment notes this is "for testing purposes only," consider whether these aggressive security bypasses are necessary. Alternative approaches might include: 1) configuring proper allowed origins/hosts (as done in the lock file's entrypointArgs), 2) using --disable-blink-features=AutomationControlled alone, or 3) investigating why ERR_BLOCKED_BY_CLIENT occurs and addressing the root cause (e.g., network policies, ad blockers, or container restrictions) rather than disabling security features.
| # Launch options to prevent ERR_BLOCKED_BY_CLIENT errors in CI testing | |
| # Security note: These flags disable web security features for testing purposes only | |
| PLAYWRIGHT_LAUNCH_OPTIONS: '{"args": ["--disable-blink-features=AutomationControlled", "--disable-web-security", "--disable-features=IsolateOrigins,site-per-process"]}' | |
| # Launch options to reduce CI-specific blocking (e.g., automation detection) without disabling web security | |
| PLAYWRIGHT_LAUNCH_OPTIONS: '{"args": ["--disable-blink-features=AutomationControlled"]}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states "Lock file intentionally not modified per instructions," but this means the changes to the .md file will not take effect until the workflow is recompiled using
gh aw compile nightly-mcp-stress-test. According to the codebase documentation, agentic workflows must be compiled from .md to .lock.yml files before they can run. Without updating the lock file, these environment variable changes will not be applied to the actual workflow execution. Either the lock file needs to be updated (recompiled), or if there's a specific reason not to update it, this should be clarified.