Skip to content

Fix markdown rendering: indent RPC message code blocks under bullet points #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
Feb 5, 2026
Merged

Fix markdown rendering: indent RPC message code blocks under bullet points #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7efa099
Initial plan
Copilot Feb 5, 2026
b57628a
Fix inconsistent markdown rendering by indenting code blocks in RPC m…
Copilot Feb 5, 2026
21c15e2
Apply gofmt formatting to markdown_logger_test.go
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions internal/logger/markdown_logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,22 @@ func (ml *MarkdownLogger) Log(level LogLevel, category, format string, args ...i
isPreformatted := strings.HasPrefix(message, "**") && (strings.Contains(message, "β†’") || strings.Contains(message, "←"))

if isPreformatted {
// Pre-formatted content (like RPC messages) - just add bullet and emoji
logLine = fmt.Sprintf("- %s %s %s\n", emoji, category, message)
// Pre-formatted content (like RPC messages) - add bullet and emoji
// If the message contains newlines (e.g., JSON code blocks), indent them properly
if strings.Contains(message, "\n") {
// Split the message into lines and indent continuation lines with 2 spaces
lines := strings.Split(message, "\n")
firstLine := lines[0]
// Start with the first line
logLine = fmt.Sprintf("- %s %s %s\n", emoji, category, firstLine)
// Add remaining lines with proper indentation (2 spaces to nest under bullet)
for i := 1; i < len(lines); i++ {
logLine += " " + lines[i] + "\n"
}
} else {
// Single-line pre-formatted message
logLine = fmt.Sprintf("- %s %s %s\n", emoji, category, message)
}
} else if strings.Contains(message, "\n") || strings.Contains(message, "command=") || strings.Contains(message, "args=") {
// Multi-line or technical content - use code block
logLine = fmt.Sprintf("- %s **%s**\n ```\n %s\n ```\n", emoji, category, message)
Expand Down
9 changes: 8 additions & 1 deletion internal/logger/markdown_logger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,16 @@ func TestMarkdownLoggerRPCFormatting(t *testing.T) {
assert.True(t, strings.Contains(logContent, "- πŸ” rpc **github**β†’`tools/list`"), "RPC message should be on single line without extra code block wrapping")

// Check that RPC messages with JSON blocks are properly formatted
// The title should be on one line, followed by the JSON block
// The title should be on one line, followed by the JSON block INDENTED with 2 spaces
assert.True(t, strings.Contains(logContent, "- πŸ” rpc **safeoutputs**β†’`tools/call`"), "RPC message with JSON should have title on single line")

// Verify that JSON code block lines are properly indented under the bullet point
// The empty line after the first line should be indented
assert.True(t, strings.Contains(logContent, "- πŸ” rpc **safeoutputs**β†’`tools/call`\n \n ```json"), "JSON code block should be indented with 2 spaces")

// Verify the closing code fence is also indented
assert.True(t, strings.Contains(logContent, " ```"), "Closing code fence should be indented")

// Regular multi-line messages should still use code blocks
assert.True(t, strings.Contains(logContent, "- βœ“ **backend**\n ```\n command="), "Regular multi-line messages should still use code blocks")

Expand Down
Loading