Skip to content

Fix test assertions for enhanced logging in close_older_issues #11083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jan 21, 2026
Merged

Fix test assertions for enhanced logging in close_older_issues #11083

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f08d95
Initial plan
Copilot Jan 21, 2026
c3bcd74
fix: Update close_older_issues test assertions for enhanced logging
Copilot Jan 21, 2026
07cfb64
Merge branch 'main' into copilot/fix-js-test-suite-failures
pelikhan Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions actions/setup/js/close_older_issues.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ describe("close_older_issues", () => {
const results = await closeOlderIssues(mockGithub, "owner", "repo", "", [], newIssue, "Test Workflow", "https://github.com/owner/repo/actions/runs/123");

expect(results).toHaveLength(MAX_CLOSE_COUNT);
expect(global.core.warning).toHaveBeenCalledWith(`Found 15 older issues, but only closing the first ${MAX_CLOSE_COUNT}`);
expect(global.core.warning).toHaveBeenCalledWith(`⚠️ Found 15 older issues, but only closing the first ${MAX_CLOSE_COUNT}`);
});

it("should continue on error for individual issues", async () => {
Expand Down Expand Up @@ -328,7 +328,7 @@ describe("close_older_issues", () => {
const results = await closeOlderIssues(mockGithub, "owner", "repo", "Prefix", [], newIssue, "Test Workflow", "https://github.com/owner/repo/actions/runs/123");

expect(results).toHaveLength(0);
expect(global.core.info).toHaveBeenCalledWith("No older issues found to close");
expect(global.core.info).toHaveBeenCalledWith("✓ No older issues found to close - operation complete");
});
});
});
Loading