Skip to content

Standardize error messages to use console formatting with stderr #11638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jan 24, 2026
Merged

Standardize error messages to use console formatting with stderr #11638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e12d986
Initial plan
Copilot Jan 24, 2026
4dee5ef
Initial plan: Standardize error messages to use console.FormatErrorMe…
Copilot Jan 24, 2026
96e5eaa
Standardize error messages to use console.FormatErrorMessage()
Copilot Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/github-remote-mcp-auth-test.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/cli/file_tracker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"path/filepath"
"strings"

"github.com/githubnext/gh-aw/pkg/console"
"github.com/githubnext/gh-aw/pkg/logger"
)

Expand Down Expand Up @@ -161,7 +162,7 @@ func (ft *FileTracker) RollbackModifiedFiles(verbose bool) error {
}
} else {
if verbose {
fmt.Printf(" Warning: No original content stored for %s\n", file)
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("No original content stored for %s", file)))
}
}
}
Expand Down
7 changes: 4 additions & 3 deletions pkg/cli/run_workflow_tracking.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package cli
import (
"encoding/json"
"fmt"
"os"
"os/exec"
"time"

Expand Down Expand Up @@ -83,7 +84,7 @@ func getLatestWorkflowRunWithRetry(lockFileName string, repo string, verbose boo
if err != nil {
lastErr = fmt.Errorf("failed to get workflow runs: %w", err)
if verbose {
fmt.Printf("Attempt %d/%d failed: %v\n", attempt+1, maxRetries, err)
fmt.Fprintln(os.Stderr, console.FormatErrorMessage(fmt.Sprintf("Attempt %d/%d failed: %v", attempt+1, maxRetries, err)))
}
continue
}
Expand All @@ -108,7 +109,7 @@ func getLatestWorkflowRunWithRetry(lockFileName string, repo string, verbose boo
if err := json.Unmarshal(output, &runs); err != nil {
lastErr = fmt.Errorf("failed to parse workflow run data: %w", err)
if verbose {
fmt.Printf("Attempt %d/%d failed to parse JSON: %v\n", attempt+1, maxRetries, err)
fmt.Fprintln(os.Stderr, console.FormatErrorMessage(fmt.Sprintf("Attempt %d/%d failed to parse JSON: %v", attempt+1, maxRetries, err)))
}
continue
}
Expand All @@ -129,7 +130,7 @@ func getLatestWorkflowRunWithRetry(lockFileName string, repo string, verbose boo
if parsedTime, err := time.Parse(time.RFC3339, run.CreatedAt); err == nil {
createdAt = parsedTime
} else if verbose {
fmt.Printf("Warning: Could not parse creation time '%s': %v\n", run.CreatedAt, err)
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Could not parse creation time '%s': %v", run.CreatedAt, err)))
}
}

Expand Down