Skip to content

[code-simplifier] Consolidate duplicate file deletion logic in deleteOldAgentFiles #11667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Jan 24, 2026
+24 −38
Merged

[code-simplifier] Consolidate duplicate file deletion logic in deleteOldAgentFiles #11667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 24 additions & 38 deletions pkg/cli/copilot-agents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,46 +301,32 @@ func deleteOldAgentFiles(verbose bool) error {
return nil // Not in a git repository, skip
}

agentFiles := []string{
"create-agentic-workflow.agent.md",
"debug-agentic-workflow.agent.md",
"create-shared-agentic-workflow.agent.md",
"create-agentic-workflow.md",
"setup-agentic-workflows.md",
"update-agentic-workflows.md",
"upgrade-agentic-workflows.md",
}

// Also delete the dangling singular form file from .github/aw/
awFiles := []string{
"upgrade-agentic-workflow.md", // singular form (typo/duplicate)
}

for _, agentFile := range agentFiles {
agentPath := filepath.Join(gitRoot, ".github", "agents", agentFile)

// Check if the file exists and remove it
if _, err := os.Stat(agentPath); err == nil {
if err := os.Remove(agentPath); err != nil {
return fmt.Errorf("failed to remove old agent file %s: %w", agentFile, err)
}
if verbose {
fmt.Fprintf(os.Stderr, "Removed old agent file: %s\n", agentPath)
}
}
// Map of subdirectory to list of files to delete
filesToDelete := map[string][]string{
"agents": {
"create-agentic-workflow.agent.md",
"debug-agentic-workflow.agent.md",
"create-shared-agentic-workflow.agent.md",
"create-agentic-workflow.md",
"setup-agentic-workflows.md",
"update-agentic-workflows.md",
"upgrade-agentic-workflows.md",
},
"aw": {
"upgrade-agentic-workflow.md", // singular form (typo/duplicate)
},
}

// Delete dangling files from .github/aw/
for _, awFile := range awFiles {
awPath := filepath.Join(gitRoot, ".github", "aw", awFile)

// Check if the file exists and remove it
if _, err := os.Stat(awPath); err == nil {
if err := os.Remove(awPath); err != nil {
return fmt.Errorf("failed to remove old aw file %s: %w", awFile, err)
}
if verbose {
fmt.Fprintf(os.Stderr, "Removed old aw file: %s\n", awPath)
for subdir, files := range filesToDelete {
for _, file := range files {
path := filepath.Join(gitRoot, ".github", subdir, file)
if _, err := os.Stat(path); err == nil {
if err := os.Remove(path); err != nil {
return fmt.Errorf("failed to remove old %s file %s: %w", subdir, file, err)
}
if verbose {
fmt.Fprintf(os.Stderr, "Removed old %s file: %s\n", subdir, path)
}
}
}
}
Expand Down