Skip to content

Add error wrapping to compiler activation job builders #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jan 24, 2026
Merged

Add error wrapping to compiler activation job builders #11670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec468c
Initial plan
Copilot Jan 24, 2026
08f354d
Add error wrapping to compiler activation job builders
Copilot Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/workflow/compiler_activation_jobs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func (c *Compiler) buildPreActivationJob(data *WorkflowData, needsPermissionChec
// Extract custom steps and outputs from jobs.pre-activation if present
customSteps, customOutputs, err := c.extractPreActivationCustomFields(data.Jobs)
if err != nil {
return nil, err
return nil, fmt.Errorf("failed to extract pre-activation custom fields: %w", err)
}

// Add setup step to copy activation scripts (required - no inline fallback)
Expand Down Expand Up @@ -642,7 +642,7 @@ func (c *Compiler) buildMainJob(data *WorkflowData, activationJobCreated bool) (
// but capture it into a string instead of writing directly
var stepBuilder strings.Builder
if err := c.generateMainJobSteps(&stepBuilder, data); err != nil {
return nil, err
return nil, fmt.Errorf("failed to generate main job steps: %w", err)
}

// Split the steps content into individual step entries
Expand Down