Skip to content

Fix update_project mutation missing color field for single-select options #6604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnkiefer merged 4 commits into from
Dec 16, 2025
Merged

Fix update_project mutation missing color field for single-select options #6604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dba9450
Initial plan
Copilot Dec 16, 2025
b1f7a40
Fix update_project GraphQL mutation to include color field for single…
Copilot Dec 16, 2025
836b09c
Fix complete: update_project color field handling verified with tests
Copilot Dec 16, 2025
75ddb20
Merge branch 'main' into copilot/analyze-campaign-run-errors
mnkiefer Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/daily-file-diet.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions .github/workflows/go-file-size-reduction.campaign.g.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pkg/workflow/js/update_project.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,7 @@ async function updateProject(output) {
options {
id
name
color
}
}
}
Expand Down Expand Up @@ -718,8 +719,8 @@ async function updateProject(output) {
try {
// Build options array with existing options plus the new one
const allOptions = [
...field.options.map(o => ({ name: o.name, description: "" })),
{ name: String(fieldValue), description: "" },
...field.options.map(o => ({ name: o.name, description: "", color: o.color || "GRAY" })),
{ name: String(fieldValue), description: "", color: "GRAY" },
];

const createOptionResult = await github.graphql(
Expand Down
67 changes: 67 additions & 0 deletions pkg/workflow/js/update_project.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,73 @@ describe("updateProject", () => {
expect(updateCall).toBeDefined();
});

it("creates a new option in single select field with colors for existing options", async () => {
const projectUrl = "https://github.com/orgs/testowner/projects/60";
const output = {
type: "update_project",
project: projectUrl,
content_type: "issue",
content_number: 16,
fields: { Status: "Closed - Not Planned" },
};

queueResponses([
repoResponse(),
viewerResponse(),
orgProjectV2Response(projectUrl, 60, "project-status"),
linkResponse,
issueResponse("issue-id-16"),
existingItemResponse("issue-id-16", "item-status"),
fieldsResponse([
{
id: "field-status",
name: "Status",
options: [
{ id: "opt-todo", name: "Todo", color: "GRAY" },
{ id: "opt-in-progress", name: "In Progress", color: "YELLOW" },
{ id: "opt-done", name: "Done", color: "GREEN" },
{ id: "opt-closed", name: "Closed", color: "PURPLE" },
],
},
]),
// Response for updateProjectV2Field mutation
{
updateProjectV2Field: {
projectV2Field: {
id: "field-status",
options: [
{ id: "opt-todo", name: "Todo" },
{ id: "opt-in-progress", name: "In Progress" },
{ id: "opt-done", name: "Done" },
{ id: "opt-closed", name: "Closed" },
{ id: "opt-closed-not-planned", name: "Closed - Not Planned" },
],
},
},
},
updateFieldValueResponse(),
]);

await updateProject(output);

// Find the updateProjectV2Field mutation call
const updateFieldCall = mockGithub.graphql.mock.calls.find(([query]) => query.includes("updateProjectV2Field"));
expect(updateFieldCall).toBeDefined();

// Verify that the mutation includes color for all options
const options = updateFieldCall[1].options;
expect(options).toHaveLength(5); // 4 existing + 1 new

// Check that all existing options have their colors preserved
expect(options[0]).toEqual({ name: "Todo", description: "", color: "GRAY" });
expect(options[1]).toEqual({ name: "In Progress", description: "", color: "YELLOW" });
expect(options[2]).toEqual({ name: "Done", description: "", color: "GREEN" });
expect(options[3]).toEqual({ name: "Closed", description: "", color: "PURPLE" });

// Check that the new option has a default color
expect(options[4]).toEqual({ name: "Closed - Not Planned", description: "", color: "GRAY" });
});

it("warns when a field cannot be created", async () => {
const projectUrl = "https://github.com/orgs/testowner/projects/60";
const output = {
Expand Down
Loading