Skip to content

Convert single-value enums to const and add URI format constraints #8145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Convert single-value enums to const and add URI format constraints #8145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04a6a2d
Initial plan
Copilot Dec 30, 2025
2c21e2a
Convert single-value enums to const and add URI format constraints
Copilot Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/parser/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,7 +2020,7 @@ func TestValidateMCPConfigWithSchema(t *testing.T) {
},
toolName: "test-tool",
wantErr: true,
errContains: "minLength",
errContains: "valid uri", // Format validation takes precedence over minLength
},
{
name: "valid stdio MCP config with container",
Expand Down
11 changes: 7 additions & 4 deletions pkg/parser/schemas/included_file_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@
"properties": {
"mode": {
"type": "string",
"enum": ["http"],
"const": "http",
"default": "http",
"description": "Deprecated: Transport mode for the safe-inputs MCP server. This field is ignored as only 'http' mode is supported. The server always starts as a separate step.",
"deprecated": true,
Expand Down Expand Up @@ -829,7 +829,7 @@
"oneOf": [
{
"type": "string",
"enum": ["defaults"],
"const": "defaults",
"description": "Use default network access"
},
{
Expand Down Expand Up @@ -858,7 +858,7 @@
},
{
"type": "string",
"enum": ["disable"],
"const": "disable",
"description": "Disable AWF firewall (triggers warning if allowed != *, error in strict mode if allowed is not * or engine does not support firewall)"
},
{
Expand Down Expand Up @@ -998,6 +998,7 @@
},
"registry": {
"type": "string",
"format": "uri",
"description": "URI to the installation location when MCP is installed from a registry"
},
"command": {
Expand Down Expand Up @@ -1130,15 +1131,17 @@
"properties": {
"type": {
"type": "string",
"enum": ["http"],
"const": "http",
"description": "MCP connection type for HTTP"
},
"registry": {
"type": "string",
"format": "uri",
"description": "URI to the installation location when MCP is installed from a registry"
},
"url": {
"type": "string",
"format": "uri",
"minLength": 1,
"description": "URL for HTTP MCP connections"
},
Expand Down
24 changes: 14 additions & 10 deletions pkg/parser/schemas/main_workflow_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@
"description": "Types of check suite events",
"items": {
"type": "string",
"enum": ["completed"]
"const": "completed"
}
}
}
Expand Down Expand Up @@ -902,7 +902,7 @@
"description": "Types of merge group events",
"items": {
"type": "string",
"enum": ["checks_requested"]
"const": "checks_requested"
}
}
}
Expand Down Expand Up @@ -1156,7 +1156,7 @@
"description": "Types of watch events",
"items": {
"type": "string",
"enum": ["started"]
"const": "started"
}
}
}
Expand Down Expand Up @@ -1406,7 +1406,7 @@
},
"all": {
"type": "string",
"enum": ["read"],
"const": "read",
"description": "Permission shorthand that applies read access to all permission scopes. Can be combined with specific write permissions to override individual scopes. 'write' is not allowed for all."
}
}
Expand Down Expand Up @@ -1950,7 +1950,7 @@
"oneOf": [
{
"type": "string",
"enum": ["defaults"],
"const": "defaults",
"description": "Use default network permissions (basic infrastructure: certificates, JSON schema, Ubuntu, etc.)"
},
{
Expand Down Expand Up @@ -1981,7 +1981,7 @@
},
{
"type": "string",
"enum": ["disable"],
"const": "disable",
"description": "Disable AWF firewall (triggers warning if allowed != *, error in strict mode if allowed is not * or engine does not support firewall)"
},
{
Expand Down Expand Up @@ -3185,6 +3185,7 @@
},
"url": {
"type": "string",
"format": "uri",
"description": "URL for HTTP mode MCP servers"
},
"headers": {
Expand Down Expand Up @@ -4979,8 +4980,8 @@
"oneOf": [
{
"type": "string",
"enum": ["all"],
"description": "Allow any authenticated user to trigger the workflow (\u26a0\ufe0f disables permission checking entirely - use with caution)"
"const": "all",
"description": "Allow any authenticated user to trigger the workflow (⚠️ disables permission checking entirely - use with caution)"
},
{
"type": "array",
Expand Down Expand Up @@ -5236,7 +5237,7 @@
"properties": {
"mode": {
"type": "string",
"enum": ["http"],
"const": "http",
"default": "http",
"description": "Deprecated: Transport mode for the safe-inputs MCP server. This field is ignored as only 'http' mode is supported. The server always starts as a separate step.",
"deprecated": true,
Expand Down Expand Up @@ -5515,6 +5516,7 @@
},
"registry": {
"type": "string",
"format": "uri",
"description": "URI to the installation location when MCP is installed from a registry"
},
"command": {
Expand Down Expand Up @@ -5651,15 +5653,17 @@
"properties": {
"type": {
"type": "string",
"enum": ["http"],
"const": "http",
"description": "MCP connection type for HTTP"
},
"registry": {
"type": "string",
"format": "uri",
"description": "URI to the installation location when MCP is installed from a registry"
},
"url": {
"type": "string",
"format": "uri",
"minLength": 1,
"description": "URL for HTTP MCP connections"
},
Expand Down
10 changes: 6 additions & 4 deletions pkg/parser/schemas/mcp_config_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,12 @@
},
"registry": {
"type": "string",
"format": "uri",
"description": "URI to the installation location when MCP is installed from a registry"
},
"url": {
"type": "string",
"format": "uri",
"minLength": 1,
"description": "URL for HTTP MCP connections",
"examples": ["http://localhost:8765", "https://api.example.com/mcp"]
Expand Down Expand Up @@ -200,7 +202,7 @@
"if": {
"properties": {
"type": {
"enum": ["http"]
"const": "http"
}
}
},
Expand All @@ -215,7 +217,7 @@
"if": {
"properties": {
"type": {
"enum": ["stdio"]
"const": "stdio"
}
}
},
Expand Down Expand Up @@ -257,7 +259,7 @@
"then": {
"properties": {
"type": {
"enum": ["stdio"]
"const": "stdio"
}
}
}
Expand All @@ -270,7 +272,7 @@
"required": ["container"],
"properties": {
"type": {
"enum": ["stdio"]
"const": "stdio"
}
}
}
Expand Down