Skip to content

Remove unused logger variables causing lint failures #8514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jan 1, 2026
Merged

Remove unused logger variables causing lint failures #8514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56ae282
Initial plan
Copilot Jan 1, 2026
fa25638
Initial plan for CI cleanup - fix linting issues
Copilot Jan 1, 2026
e0833d0
Remove unused logger variables to fix linting issues
Copilot Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/workflow/copilot_engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,8 @@ package workflow

import (
"github.com/githubnext/gh-aw/pkg/constants"
"github.com/githubnext/gh-aw/pkg/logger"
)

var copilotLog = logger.New("workflow:copilot_engine")

const logsFolder = "/tmp/gh-aw/sandbox/agent/logs/"

// CopilotEngine represents the GitHub Copilot CLI agentic engine.
Expand Down
3 changes: 0 additions & 3 deletions pkg/workflow/copilot_engine_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,8 @@ import (
"strings"

"github.com/githubnext/gh-aw/pkg/constants"
"github.com/githubnext/gh-aw/pkg/logger"
)

var copilotToolsLog = logger.New("workflow:copilot_engine_tools")

// computeCopilotToolArguments computes the --allow-tool arguments for Copilot CLI based on tool configurations.
// It handles bash/shell tools, edit tools, safe outputs, safe inputs, and MCP server tools.
// Returns a sorted list of arguments ready to be passed to the Copilot CLI.
Expand Down
60 changes: 31 additions & 29 deletions pkg/workflow/schemas/github-workflow.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,32 +122,6 @@
"required": ["image"],
"additionalProperties": false
},
"snapshot": {
"$comment": "https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idsnapshot",
"description": "Specifies a custom image to generate for GitHub Actions workflows. This can be a simple image name string or a detailed mapping with version information.",
"oneOf": [
{
"type": "string",
"description": "A simple image name string for the snapshot"
},
{
"type": "object",
"properties": {
"image-name": {
"type": "string",
"description": "The name of the image to generate"
},
"version": {
"type": "string",
"description": "The version of the image",
"pattern": "^[a-zA-Z0-9._-]+$"
}
},
"required": ["image-name"],
"additionalProperties": false
}
]
},
"defaults": {
"type": "object",
"properties": {
Expand Down Expand Up @@ -377,6 +351,34 @@
}
]
},
"snapshot": {
"$comment": "https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idsnapshot",
"description": "You can use `jobs.<job_id>.snapshot` to generate a custom image.\nAdd the snapshot keyword to the job, using either the string syntax or mapping syntax as shown in https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images#generating-a-custom-image.\nEach job that includes the snapshot keyword creates a separate image. To generate only one image or image version, include all workflow steps in a single job. Each successful run of a job that includes the snapshot keyword creates a new version of that image.\nFor more information, see https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images.",
"oneOf": [
{
"$comment": "https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images#string-syntax",
"type": "string",
"description": "You can use the string syntax with `snapshot` to define the image name. This method creates a new image or adds a new version to an existing image with the same name. You cannot specify a version number using this syntax."
},
{
"$comment": "https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images#mapping-syntax",
"type": "object",
"additionalProperties": false,
"description": "You can use the mapping syntax with `snapshot` to define both the `image-name` and the optional `version`. When you specify a major version, the minor versioning automatically increments if that major version already exists. Patch versions are not supported.",
"properties": {
"image-name": {
"type": "string"
},
"version": {
"$comment": "https://docs.github.com/en/actions/how-tos/manage-runners/larger-runners/use-custom-images#specifying-a-version-in-your-workflow",
"type": "string",
"pattern": "^\\d+(\\.\\d+|\\*)?$"
}
},
"required": ["image-name"]
}
]
},
"step": {
"type": "object",
"additionalProperties": false,
Expand Down Expand Up @@ -649,6 +651,9 @@
"needs": {
"$ref": "#/definitions/jobNeeds"
},
"snapshot": {
"$ref": "#/definitions/snapshot"
},
"permissions": {
"$ref": "#/definitions/permissions"
},
Expand Down Expand Up @@ -831,9 +836,6 @@
"$ref": "#/definitions/concurrency"
}
]
},
"snapshot": {
"$ref": "#/definitions/snapshot"
}
},
"required": ["runs-on"],
Expand Down