Thoughts about the codebase

[ArinGhazarian]

As I started taking a look at the codebase, I noticed some stuff and thought it would be better to write them down so we can iterate over them and probably create some action items out of them. These are just my ideas and do not necessarily mean that we need to do/follow them.

1. Lack of interfaces (contracts)
   I am very fund of contract based development and use interfaces heavily. So instead of depending on concrete types/implementations we can just depend on abstractions. IMO it makes to code easier to maintain and test. Most methods are marked as virtual because otherwise it'd be close to impossible to mock them, but with using proper interfaces we can get rid of the virtuals.
2. Should we inject a logger to lower level clients (i.e. AdoClient)? I think we might be able to move the logging to higher levels (i.e. AdoApi).
3. We can use a well versed and easy to use an maintain logging library like NLog instead of OctoLogger.
4. GitHub already has OctoKit.net for its REST API and OctoKit.GraphQL.net for its GraphQL API. General purpose GQL libraries also exist, there is a list of recommended ones in GraphQL.org. We used GraphQL-client before but there might be better ones too. We can have a quick spike on this and pick one from the recommended list of GQL clients.
5. (opinionated) I really like using FluentAssertions + xUnit. It makes the code so much eaiser to read and follow.
6. I would use a more robust http library like RestSharp over HttpClient.
7. IDisposable pattern can be simplified (despiste CA10631) since we don't have any Finalizers. Also if we consider making our classes sealed we can easily use a simpler Dispose method.
8. For retries we can consider using Polly. Microsoft also recommends it 😃.
9. We can use some C#9/10 goodies and probably upgrade to .NET 6.
10. Regarding the project layout, David Fowler sugged this and lots of people liked it. It is of course opinionated but lots of .NET projects are following that layout.
11. We can consider containerizing the way we did in Octoshift.