Mcp UI Apps w/ HTTP Stack #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

mattdholloway wants to merge 129 commits into main from mcp-ui-apps-3-http-stack

+16,041 −1,474

.github/workflows/code-scanning.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -74,6 +74,18 @@ jobs: @@
               go-version: ${{ fromJSON(steps.resolve-environment.outputs.environment).configuration.go.version }}
               cache: false
+          - name: Set up Node.js
+            if: matrix.language == 'go'
+            uses: actions/setup-node@v4
+            with:
+              node-version: "20"
+              cache: "npm"
+              cache-dependency-path: ui/package-lock.json
+          - name: Build UI
+            if: matrix.language == 'go'
+            run: script/build-ui
           - name: Autobuild
             uses: github/codeql-action/autobuild@v4
@@ Expand Down @@

.github/workflows/docs-check.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,16 @@ jobs: @@
         - name: Checkout code
           uses: actions/checkout@v6
+        - name: Set up Node.js
+          uses: actions/setup-node@v4
+          with:
+            node-version: "20"
+            cache: "npm"
+            cache-dependency-path: ui/package-lock.json
+        - name: Build UI
+          run: script/build-ui
         - name: Set up Go
           uses: actions/setup-go@v6
           with:
@@ Expand Down @@

.github/workflows/go.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -25,6 +25,17 @@ jobs: @@
           - name: Check out code
             uses: actions/checkout@v6
+          - name: Set up Node.js
+            uses: actions/setup-node@v4
+            with:
+              node-version: "20"
+              cache: "npm"
+              cache-dependency-path: ui/package-lock.json
+          - name: Build UI
+            shell: bash
+            run: script/build-ui
           - name: Set up Go
             uses: actions/setup-go@v6
             with:
@@ Expand All / @@ -34,6 +45,7 @@ jobs: @@
             run: go mod tidy -diff
           - name: Run unit tests
+            shell: bash
             run: script/test
           - name: Build
@@ Expand Down @@

.github/workflows/goreleaser.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,16 @@ jobs: @@
           - name: Check out code
             uses: actions/checkout@v6
+          - name: Set up Node.js
+            uses: actions/setup-node@v4
+            with:
+              node-version: "20"
+              cache: "npm"
+              cache-dependency-path: ui/package-lock.json
+          - name: Build UI
+            run: script/build-ui
           - name: Set up Go
             uses: actions/setup-go@v6
             with:
@@ Expand Down @@

.github/workflows/license-check.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -32,6 +32,16 @@ jobs: @@
               GH_TOKEN: ${{ github.token }}
             run: gh pr checkout ${{ github.event.pull_request.number }}
+          - name: Set up Node.js
+            uses: actions/setup-node@v4
+            with:
+              node-version: "20"
+              cache: "npm"
+              cache-dependency-path: ui/package-lock.json
+          - name: Build UI
+            run: script/build-ui
           - name: Set up Go
             uses: actions/setup-go@v6
             with:
@@ Expand Down @@

.github/workflows/lint.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -14,6 +14,13 @@ jobs: @@
         runs-on: ubuntu-latest
         steps:
           - uses: actions/checkout@v6
+          - uses: actions/setup-node@v4
+            with:
+              node-version: "20"
+              cache: "npm"
+              cache-dependency-path: ui/package-lock.json
+          - name: Build UI
+            run: script/build-ui
           - uses: actions/setup-go@v6
             with:
               go-version: stable
@@ Expand Down @@

.github/workflows/mcp-diff.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,14 @@ jobs: @@
             with:
               fetch-depth: 0
+          - name: Set up Node.js
+            uses: actions/setup-node@v4
+            with:
+              node-version: '20'
+          - name: Build UI
+            run: script/build-ui
           - name: Run MCP Server Diff
             uses: SamMorrowDrums/mcp-server-diff@v2.3.5
             with:
@@ Expand Down @@

.gitignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -23,3 +23,12 @@ e2e.test @@
     .history
     conformance-report/
+    # UI build artifacts
+    ui/dist/
+    ui/node_modules/
+    # Embedded UI assets (built from ui/)
+    pkg/github/ui_dist/*
+    !pkg/github/ui_dist/.gitkeep
+    !pkg/github/ui_dist/.placeholder.html

.vscode/launch.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -23,6 +23,16 @@ @@
                 "program": "cmd/github-mcp-server/main.go",
                 "args": ["stdio", "--read-only"],
                 "console": "integratedTerminal",
+            },
+            {
+                "name": "Launch http server",
+                "type": "go",
+                "request": "launch",
+                "mode": "auto",
+                "cwd": "${workspaceFolder}",
+                "program": "cmd/github-mcp-server/main.go",
+                "args": ["http", "--port", "8082"],
+                "console": "integratedTerminal",
             }
         ]
     }

Dockerfile

-Original file line number
+Diff line change
@@ -1,3 +1,12 @@
+    FROM node:20-alpine AS ui-build
+    WORKDIR /app
+    COPY ui/package*.json ./ui/
+    RUN cd ui && npm ci
+    COPY ui/ ./ui/
+    # Create output directory and build - vite outputs directly to pkg/github/ui_dist/
+    RUN mkdir -p ./pkg/github/ui_dist && \
+        cd ui && npm run build
     FROM golang:1.25.6-alpine AS build
     ARG VERSION="dev"
@@ Expand All / @@ -8,11 +17,15 @@ WORKDIR /build @@
     RUN --mount=type=cache,target=/var/cache/apk \
         apk add git
+    # Copy source code (including ui_dist placeholder)
+    COPY . .
+    # Copy built UI assets over the placeholder
+    COPY --from=ui-build /app/pkg/github/ui_dist/* ./pkg/github/ui_dist/
     # Build the server
-    # go build automatically download required module dependencies to /go/pkg/mod
     RUN --mount=type=cache,target=/go/pkg/mod \
         --mount=type=cache,target=/root/.cache/go-build \
-        --mount=type=bind,target=. \
         CGO_ENABLED=0 go build -ldflags="-s -w -X main.version=${VERSION} -X main.commit=$(git rev-parse HEAD) -X main.date=$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
         -o /bin/github-mcp-server ./cmd/github-mcp-server
@@ Expand Down @@

README.md

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -843,6 +843,11 @@ The following sets of tools are available:
  
      - `title`: Issue title (string, optional)

      - `type`: Type of this issue. Only use if the repository has issue types configured. Use list_issue_types tool to get valid type values for the organization. If the repository doesn't support issue types, omit this parameter. (string, optional)

    - **list_assignees** - List assignable users

      - **Required OAuth Scopes**: `repo`

      - `owner`: Repository owner (string, required)

      - `repo`: Repository name (string, required)

    - **list_issue_types** - List available issue types

      - **Required OAuth Scopes**: `read:org`

      - **Accepted OAuth Scopes**: `admin:org`, `read:org`, `write:org`

    @@ -860,6 +865,12 @@ The following sets of tools are available:
  
      - `since`: Filter by date (ISO 8601 timestamp) (string, optional)

      - `state`: Filter by state, by default both open and closed issues are returned when not provided (string, optional)

    - **list_milestones** - List milestones

      - **Required OAuth Scopes**: `repo`

      - `owner`: Repository owner (string, required)

      - `repo`: Repository name (string, required)

      - `state`: Filter by state (open, closed, all). Default: open (string, optional)

    - **search_issues** - Search issues

      - **Required OAuth Scopes**: `repo`

      - `order`: Sort order (string, optional)

    @@ -1043,14 +1054,14 @@ The following sets of tools are available:
  
    - **create_pull_request** - Open new pull request

      - **Required OAuth Scopes**: `repo`

      - `base`: Branch to merge into (string, required)

      - `base`: Branch to merge into (string, optional)

      - `body`: PR description (string, optional)

      - `draft`: Create as draft PR (boolean, optional)

      - `head`: Branch containing changes (string, required)

      - `head`: Branch containing changes (string, optional)

      - `maintainer_can_modify`: Allow maintainer edits (boolean, optional)

      - `owner`: Repository owner (string, required)

      - `repo`: Repository name (string, required)

      - `title`: PR title (string, required)

      - `title`: PR title (string, optional)

    - **list_pull_requests** - List pull requests

      - **Required OAuth Scopes**: `repo`

cmd/github-mcp-server/main.go

-Original file line number
+Diff line change
@@ Expand Up / @@ -9,6 +9,7 @@ import ( @@
     	"github.com/github/github-mcp-server/internal/ghmcp"
     	"github.com/github/github-mcp-server/pkg/github"
+    	ghhttp "github.com/github/github-mcp-server/pkg/http"
     	"github.com/spf13/cobra"
     	"github.com/spf13/pflag"
     	"github.com/spf13/viper"
@@ Expand Down Expand Up / @@ -89,6 +90,31 @@ var ( @@
     			return ghmcp.RunStdioServer(stdioServerConfig)
     		},
     	}
+    	httpCmd = &cobra.Command{
+    		Use:   "http",
+    		Short: "Start HTTP server",
+    		Long:  `Start an HTTP server that listens for MCP requests over HTTP.`,
+    		RunE: func(_ *cobra.Command, _ []string) error {
+    			ttl := viper.GetDuration("repo-access-cache-ttl")
+    			httpConfig := ghhttp.ServerConfig{
+    				Version:              version,
+    				Host:                 viper.GetString("host"),
+    				Port:                 viper.GetInt("port"),
+    				BaseURL:              viper.GetString("base-url"),
+    				ResourcePath:         viper.GetString("base-path"),
+    				ExportTranslations:   viper.GetBool("export-translations"),
+    				EnableCommandLogging: viper.GetBool("enable-command-logging"),
+    				LogFilePath:          viper.GetString("log-file"),
+    				ContentWindowSize:    viper.GetInt("content-window-size"),
+    				LockdownMode:         viper.GetBool("lockdown-mode"),
+    				RepoAccessCacheTTL:   &ttl,
+    				ScopeChallenge:       viper.GetBool("scope-challenge"),
+    			}
+    			return ghhttp.RunHTTPServer(httpConfig)
+    		},
+    	}
     )
     func init() {
@@ Expand All / @@ -112,6 +138,12 @@ func init() { @@
     	rootCmd.PersistentFlags().Bool("insiders", false, "Enable insiders features")
     	rootCmd.PersistentFlags().Duration("repo-access-cache-ttl", 5*time.Minute, "Override the repo access cache TTL (e.g. 1m, 0s to disable)")
+    	// HTTP-specific flags
+    	httpCmd.Flags().Int("port", 8082, "HTTP server port")
+    	httpCmd.Flags().String("base-url", "", "Base URL where this server is publicly accessible (for OAuth resource metadata)")
+    	httpCmd.Flags().String("base-path", "", "Externally visible base path for the HTTP server (for OAuth resource metadata)")
+    	httpCmd.Flags().Bool("scope-challenge", false, "Enable OAuth scope challenge responses and tool filtering based on token scopes")
     	// Bind flag to viper
     	_ = viper.BindPFlag("toolsets", rootCmd.PersistentFlags().Lookup("toolsets"))
     	_ = viper.BindPFlag("tools", rootCmd.PersistentFlags().Lookup("tools"))
@@ Expand All / @@ -126,9 +158,13 @@ func init() { @@
     	_ = viper.BindPFlag("lockdown-mode", rootCmd.PersistentFlags().Lookup("lockdown-mode"))
     	_ = viper.BindPFlag("insiders", rootCmd.PersistentFlags().Lookup("insiders"))
     	_ = viper.BindPFlag("repo-access-cache-ttl", rootCmd.PersistentFlags().Lookup("repo-access-cache-ttl"))
+    	_ = viper.BindPFlag("port", httpCmd.Flags().Lookup("port"))
+    	_ = viper.BindPFlag("base-url", httpCmd.Flags().Lookup("base-url"))
+    	_ = viper.BindPFlag("base-path", httpCmd.Flags().Lookup("base-path"))
+    	_ = viper.BindPFlag("scope-challenge", httpCmd.Flags().Lookup("scope-challenge"))
     	// Add subcommands
     	rootCmd.AddCommand(stdioCmd)
+    	rootCmd.AddCommand(httpCmd)
     }
     func initConfig() {
@@ Expand Down @@

docs/remote-server.md

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -121,13 +121,15 @@ The Remote GitHub MCP server supports the following URL path patterns:
  
    - `/` - Default toolset (see ["default" toolset](../README.md#default-toolset))

    - `/readonly` - Default toolset in read-only mode

    - `/insiders` - Default toolset with insiders mode enabled

    - `/insiders/readonly` - Default toolset with insiders mode in read-only mode

    - `/readonly/insiders` - Default toolset in read-only mode with insiders mode enabled

    - `/x/all` - All available toolsets

    - `/x/all/readonly` - All available toolsets in read-only mode

    - `/x/all/insiders` - All available toolsets with insiders mode enabled

    - `/x/all/readonly/insiders` - All available toolsets in read-only mode with insiders mode enabled

    - `/x/{toolset}` - Single specific toolset

    - `/x/{toolset}/readonly` - Single specific toolset in read-only mode

    - `/x/{toolset}/insiders` - Single specific toolset with insiders mode enabled

    - `/x/{toolset}/readonly/insiders` - Single specific toolset in read-only mode with insiders mode enabled

    Note: `{toolset}` can only be a single toolset, not a comma-separated list. To combine multiple toolsets, use the `X-MCP-Toolsets` header instead. Path modifiers like `/readonly` and `/insiders` can be combined with the `X-MCP-Insiders` or `X-MCP-Readonly` headers.

go.mod

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,6 +17,7 @@ require ( @@
     	github.com/aymerick/douceur v0.2.0 // indirect
     	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
     	github.com/fsnotify/fsnotify v1.9.0 // indirect
+    	github.com/go-chi/chi/v5 v5.2.3
     	github.com/go-openapi/jsonpointer v0.19.5 // indirect
     	github.com/go-openapi/swag v0.21.1 // indirect
     	github.com/go-viper/mapstructure/v2 v2.5.0
@@ Expand Down @@

go.sum

-Original file line number
+Diff line change
@@ Expand Up @@
     github.com/frankban/quicktest v1.14.6/go.mod h1:4ptaffx2x8+WTWXmUCuVU6aPUX1/Mz7zb5vbUoiM6w0=
     github.com/fsnotify/fsnotify v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
     github.com/fsnotify/fsnotify v1.9.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
+    github.com/go-chi/chi/v5 v5.2.3 h1:WQIt9uxdsAbgIYgid+BpYc+liqQZGMHRaUwp0JUcvdE=
+    github.com/go-chi/chi/v5 v5.2.3/go.mod h1:L2yAIGWB3H+phAw1NxKwWM+7eUH/lU8pOMm5hHcoops=
     github.com/go-openapi/jsonpointer v0.19.5 h1:gZr+CIYByUqjcgeLXnQu2gHYQC9o73G2XUeOFYEICuY=
     github.com/go-openapi/jsonpointer v0.19.5/go.mod h1:Pl9vOtqEWErmShwVjC8pYs9cog34VGT37dQOVbmoatg=
     github.com/go-openapi/swag v0.19.5/go.mod h1:POnQmlKehdgb5mhVOsnJFsivZCEZ/vjK9gh66Z9tfKk=
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mcp UI Apps w/ HTTP Stack #1961

Diff view

Diff view

There are no files selected for viewing

Uh oh!