fix: ensure app is built before accessing global components in integration test

Co-authored-by: GrantBirki <23362539+GrantBirki@users.noreply.github.com>

Author: Copilot

lib/hooks/plugins/instruments/failbot.rb

@@ -40,4 +40,4 @@ def warning(message, context = {})
       end
     end
   end
-end
+end

lib/hooks/plugins/instruments/failbot_base.rb

@@ -63,4 +63,4 @@ def capture(context = {})
       end
     end
   end
-end
+end

lib/hooks/plugins/instruments/stats.rb

@@ -42,4 +42,4 @@ def timing(metric_name, duration, tags = {})
       end
     end
   end
-end
+end

lib/hooks/plugins/instruments/stats_base.rb

@@ -67,4 +67,4 @@ def measure(metric_name, tags = {})
       end
     end
   end
-end
+end

spec/integration/global_lifecycle_hooks_spec.rb

@@ -142,6 +142,9 @@ def report(error_or_message, context = {})
       end
     end
 
+    # Ensure the app is built and plugins are loaded before accessing global components
+    app
+
     original_stats = Hooks::Core::GlobalComponents.stats
     original_failbot = Hooks::Core::GlobalComponents.failbot
 

spec/unit/lib/hooks/core/plugin_loader_instruments_spec.rb

@@ -29,10 +29,10 @@
       })
     end
 
-  describe ".load_custom_instrument_plugins" do
-    it "loads custom stats instrument plugins" do
-      # Create a custom stats plugin file
-      custom_stats_content = <<~RUBY
+    describe ".load_custom_instrument_plugins" do
+      it "loads custom stats instrument plugins" do
+        # Create a custom stats plugin file
+        custom_stats_content = <<~RUBY
         class CustomStats < Hooks::Plugins::Instruments::StatsBase
           def record(metric_name, value, tags = {})
             # Custom implementation
@@ -48,17 +48,17 @@ def timing(metric_name, duration, tags = {})
         end
       RUBY
 
-      File.write(File.join(test_plugin_dir, "custom_stats.rb"), custom_stats_content)
+        File.write(File.join(test_plugin_dir, "custom_stats.rb"), custom_stats_content)
 
-      expect { described_class.send(:load_custom_instrument_plugins, test_plugin_dir) }.not_to raise_error
+        expect { described_class.send(:load_custom_instrument_plugins, test_plugin_dir) }.not_to raise_error
 
-      # Verify the stats plugin was loaded
-      expect(described_class.instrument_plugins[:stats]).to be_a(CustomStats)
-    end
+        # Verify the stats plugin was loaded
+        expect(described_class.instrument_plugins[:stats]).to be_a(CustomStats)
+      end
 
-    it "loads custom failbot instrument plugins" do
-      # Create a custom failbot plugin file
-      custom_failbot_content = <<~RUBY
+      it "loads custom failbot instrument plugins" do
+        # Create a custom failbot plugin file
+        custom_failbot_content = <<~RUBY
         class CustomFailbot < Hooks::Plugins::Instruments::FailbotBase
           def report(error_or_message, context = {})
             # Custom implementation
@@ -74,114 +74,114 @@ def warning(message, context = {})
         end
       RUBY
 
-      File.write(File.join(test_plugin_dir, "custom_failbot.rb"), custom_failbot_content)
+        File.write(File.join(test_plugin_dir, "custom_failbot.rb"), custom_failbot_content)
 
-      expect { described_class.send(:load_custom_instrument_plugins, test_plugin_dir) }.not_to raise_error
+        expect { described_class.send(:load_custom_instrument_plugins, test_plugin_dir) }.not_to raise_error
 
-      # Verify the failbot plugin was loaded
-      expect(described_class.instrument_plugins[:failbot]).to be_a(CustomFailbot)
-    end
+        # Verify the failbot plugin was loaded
+        expect(described_class.instrument_plugins[:failbot]).to be_a(CustomFailbot)
+      end
 
-    it "raises error for invalid inheritance" do
-      # Create an invalid plugin file that doesn't inherit from base classes
-      invalid_content = <<~RUBY
+      it "raises error for invalid inheritance" do
+        # Create an invalid plugin file that doesn't inherit from base classes
+        invalid_content = <<~RUBY
         class InvalidInstrument
           def some_method
             # This doesn't inherit from the right base class
           end
         end
       RUBY
 
-      File.write(File.join(test_plugin_dir, "invalid_instrument.rb"), invalid_content)
+        File.write(File.join(test_plugin_dir, "invalid_instrument.rb"), invalid_content)
 
-      expect do
-        described_class.send(:load_custom_instrument_plugins, test_plugin_dir)
-      end.to raise_error(StandardError, /must inherit from StatsBase or FailbotBase/)
-    end
+        expect do
+          described_class.send(:load_custom_instrument_plugins, test_plugin_dir)
+        end.to raise_error(StandardError, /must inherit from StatsBase or FailbotBase/)
+      end
 
-    it "validates class names for security" do
-      malicious_content = <<~RUBY
+      it "validates class names for security" do
+        malicious_content = <<~RUBY
         class File < Hooks::Plugins::Instruments::StatsBase
           def record(metric_name, value, tags = {})
             # Malicious implementation
           end
         end
       RUBY
 
-      File.write(File.join(test_plugin_dir, "file.rb"), malicious_content)
-
-      expect do
-        described_class.send(:load_custom_instrument_plugins, test_plugin_dir)
-      end.to raise_error(StandardError, /Invalid instrument plugin class name/)
-    end
-  end
-
-  describe ".get_instrument_plugin" do
-    before do
-      # Load default instruments
-      described_class.send(:load_default_instruments)
-    end
-
-    it "returns the stats instrument" do
-      stats = described_class.get_instrument_plugin(:stats)
-      expect(stats).to be_a(Hooks::Plugins::Instruments::Stats)
-    end
+        File.write(File.join(test_plugin_dir, "file.rb"), malicious_content)
 
-    it "returns the failbot instrument" do
-      failbot = described_class.get_instrument_plugin(:failbot)
-      expect(failbot).to be_a(Hooks::Plugins::Instruments::Failbot)
+        expect do
+          described_class.send(:load_custom_instrument_plugins, test_plugin_dir)
+        end.to raise_error(StandardError, /Invalid instrument plugin class name/)
+      end
     end
 
-    it "raises error for unknown instrument type" do
-      expect do
-        described_class.get_instrument_plugin(:unknown)
-      end.to raise_error(StandardError, "Instrument plugin 'unknown' not found")
+    describe ".get_instrument_plugin" do
+      before do
+        # Load default instruments
+        described_class.send(:load_default_instruments)
+      end
+
+      it "returns the stats instrument" do
+        stats = described_class.get_instrument_plugin(:stats)
+        expect(stats).to be_a(Hooks::Plugins::Instruments::Stats)
+      end
+
+      it "returns the failbot instrument" do
+        failbot = described_class.get_instrument_plugin(:failbot)
+        expect(failbot).to be_a(Hooks::Plugins::Instruments::Failbot)
+      end
+
+      it "raises error for unknown instrument type" do
+        expect do
+          described_class.get_instrument_plugin(:unknown)
+        end.to raise_error(StandardError, "Instrument plugin 'unknown' not found")
+      end
     end
-  end
 
-  describe ".load_default_instruments" do
-    it "loads default stats and failbot instances" do
-      described_class.send(:load_default_instruments)
+    describe ".load_default_instruments" do
+      it "loads default stats and failbot instances" do
+        described_class.send(:load_default_instruments)
 
-      expect(described_class.instrument_plugins[:stats]).to be_a(Hooks::Plugins::Instruments::Stats)
-      expect(described_class.instrument_plugins[:failbot]).to be_a(Hooks::Plugins::Instruments::Failbot)
-    end
+        expect(described_class.instrument_plugins[:stats]).to be_a(Hooks::Plugins::Instruments::Stats)
+        expect(described_class.instrument_plugins[:failbot]).to be_a(Hooks::Plugins::Instruments::Failbot)
+      end
 
-    it "doesn't override custom instruments if already loaded" do
-      # Create custom stats
-      custom_stats_content = <<~RUBY
+      it "doesn't override custom instruments if already loaded" do
+        # Create custom stats
+        custom_stats_content = <<~RUBY
         class MyCustomStats < Hooks::Plugins::Instruments::StatsBase
           def record(metric_name, value, tags = {})
             # Custom implementation
           end
         end
       RUBY
 
-      File.write(File.join(test_plugin_dir, "my_custom_stats.rb"), custom_stats_content)
-      described_class.send(:load_custom_instrument_plugins, test_plugin_dir)
+        File.write(File.join(test_plugin_dir, "my_custom_stats.rb"), custom_stats_content)
+        described_class.send(:load_custom_instrument_plugins, test_plugin_dir)
 
-      # Load defaults
-      described_class.send(:load_default_instruments)
+        # Load defaults
+        described_class.send(:load_default_instruments)
 
-      # Should still have custom stats, but default failbot
-      expect(described_class.instrument_plugins[:stats]).to be_a(MyCustomStats)
-      expect(described_class.instrument_plugins[:failbot]).to be_a(Hooks::Plugins::Instruments::Failbot)
+        # Should still have custom stats, but default failbot
+        expect(described_class.instrument_plugins[:stats]).to be_a(MyCustomStats)
+        expect(described_class.instrument_plugins[:failbot]).to be_a(Hooks::Plugins::Instruments::Failbot)
+      end
     end
-  end
 
-  describe ".valid_instrument_class_name?" do
-    it "accepts valid class names" do
-      expect(described_class.send(:valid_instrument_class_name?, "CustomStats")).to be true
-      expect(described_class.send(:valid_instrument_class_name?, "MyCustomFailbot")).to be true
-      expect(described_class.send(:valid_instrument_class_name?, "DatadogStats")).to be true
+    describe ".valid_instrument_class_name?" do
+      it "accepts valid class names" do
+        expect(described_class.send(:valid_instrument_class_name?, "CustomStats")).to be true
+        expect(described_class.send(:valid_instrument_class_name?, "MyCustomFailbot")).to be true
+        expect(described_class.send(:valid_instrument_class_name?, "DatadogStats")).to be true
+      end
+
+      it "rejects invalid class names" do
+        expect(described_class.send(:valid_instrument_class_name?, "")).to be false
+        expect(described_class.send(:valid_instrument_class_name?, "lowercaseClass")).to be false
+        expect(described_class.send(:valid_instrument_class_name?, "Class-With-Dashes")).to be false
+        expect(described_class.send(:valid_instrument_class_name?, "File")).to be false
+      end
     end
-
-    it "rejects invalid class names" do
-      expect(described_class.send(:valid_instrument_class_name?, "")).to be false
-      expect(described_class.send(:valid_instrument_class_name?, "lowercaseClass")).to be false
-      expect(described_class.send(:valid_instrument_class_name?, "Class-With-Dashes")).to be false
-      expect(described_class.send(:valid_instrument_class_name?, "File")).to be false
-    end
-  end
   end
-end
+end

spec/unit/lib/hooks/plugins/instruments/failbot_base_spec.rb

@@ -53,4 +53,4 @@
       expect(failbot).to have_received(:report).with(error, { context: "test" })
     end
   end
-end
+end

spec/unit/lib/hooks/plugins/instruments/failbot_spec.rb

@@ -44,4 +44,4 @@
       end.to raise_error(error)
     end
   end
-end
+end

spec/unit/lib/hooks/plugins/instruments/stats_base_spec.rb

@@ -39,4 +39,4 @@
       expect(stats).to have_received(:timing).with("test_metric", kind_of(Numeric), { tag: "value" })
     end
   end
-end
+end

spec/unit/lib/hooks/plugins/instruments/stats_spec.rb

@@ -34,4 +34,4 @@
       expect(result).to eq("block_result")
     end
   end
-end
+end