Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Add ids to scripts? #1663

Closed
wsoula opened this issue Sep 3, 2015 · 2 comments
Closed

Add ids to scripts? #1663

wsoula opened this issue Sep 3, 2015 · 2 comments

Comments

@wsoula
Copy link

wsoula commented Sep 3, 2015

With hubotio/hubot#803 merged should ids be added to the scripts so they can be turned off and on with https://github.com/kristenmills/hubot-command-blacklist? If so what would be the format of the ids added? I needed to turn off image me and animate me so I changed them to have the id image.me and animate.me, we could do something like that. I'm happy to help if this change is deemed appropriate.

@michaelansel
Copy link
Contributor

Yes, this is definitely something we want to do. PRs are welcome with nicely namespaced listener IDs (e.g. google.image.static, google.image.animated, google.image.corgi). The most important consideration with the IDs is that they be globally unique and consistent even if the message pattern changes.

@technicalpickles
Copy link
Contributor

It'd be good in general, but it is a lot of work, and this repository is deprecated. Considering we are trying to move scripts out of it (#1641), I think the time would be better spent updating scripts in whatever repository they end up extracted to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants